Allow cb open redirect to be modified by CB_REDIRECT_URL#180
Merged
Conversation
brandur
force-pushed
the
brandur-redirect-url
branch
from
9a95338 to
34d4168
Compare
abrightwell
force-pushed
the
main
branch
2 times, most recently
from
fe69c4e to
8805c40
Compare
brandur
force-pushed
the
brandur-redirect-url
branch
2 times, most recently
from
825bae1 to
2a5e609
Compare
Here, let `cb open` redirect to a non-standard Dashboard URL (or other internal component) by respecting the `CB_REDIRECT_URL` env var. If the var's empty, it continues to have the same behavior as before.
brandur
force-pushed
the
brandur-redirect-url
branch
from
2a5e609 to
2825866
Compare
Contributor
Author
|
@abrightwell Finally got the tests fixed up here. Mind taking a look? |
abrightwell
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, let
cb openredirect to a non-standard Dashboard URL (or otherinternal component) by respecting the
CB_REDIRECT_URLenv var. If thevar's empty, it continues to have the same behavior as before.