Handle user-set pgBouncer logfile for OTEL, mkdir#4278
Merged
benjaminjb merged 2 commits intoCrunchyData:mainfrom Sep 10, 2025
Merged
Handle user-set pgBouncer logfile for OTEL, mkdir#4278benjaminjb merged 2 commits intoCrunchyData:mainfrom
benjaminjb merged 2 commits intoCrunchyData:mainfrom
Conversation
pgBouncer allows users to set the log destination; when OTEL is enabled, we assume that destination is the default that we set. This PR patches that hole by setting OTEL to use the either the default or the user-set log destination. Issues: [PGO-2565]
Collaborator
|
There is some overlap between this PR and #4252 |
Contributor
Author
Yeah, I wanted to break down that PR into discrete parts so we could focus on the things that we still have questions about, e.g., CEL validation rules + costs, using the Log config struct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgBouncer allows users to set the log destination; when OTEL is enabled, we assume that destination is the default that we set. This PR patches that hole by setting OTEL to use the either the default or the user-set log destination.
This PR also handles creating the destination dir for the logfile.
This is a preliminary step on the way to validating the log config in v1.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Our pgBouncer OTEL settings assume a user hasn't set the logfile config, and won't work right if they do.
What is the new behavior (if this is a feature change)?
This updates OTEL with what the user sets.
Other Information:
Issues: [PGO-2565]