Prepare image file permissions in the build stage#4311
Merged
cbandy merged 2 commits intoCrunchyData:mainfrom Oct 3, 2025
Merged
Prepare image file permissions in the build stage#4311cbandy merged 2 commits intoCrunchyData:mainfrom
cbandy merged 2 commits intoCrunchyData:mainfrom
Conversation
Some files and directories were not readable by the image user. Issue: PGO-2695
benjaminjb
reviewed
Oct 3, 2025
|
|
||
| ENV GOCACHE=/var/cache/go | ||
| ENV GOMODCACHE=/var/cache/gomod | ||
| RUN --mount=type=cache,target=/var/cache \ |
Contributor
There was a problem hiding this comment.
second build was much faster with this
benjaminjb
reviewed
Oct 3, 2025
| @@ -4,21 +4,25 @@ | |||
|
|
|||
| FROM docker.io/library/golang:bookworm AS build | |||
Contributor
There was a problem hiding this comment.
Do we want to use a different image (following today's discussion)
benjaminjb
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Some files and directories were not readable by the image user. Doing
lswould fail:What is the new behavior (if this is a feature change)?
No errors from
ls. The same command above returns: