feat(vault): support configurable ENVECTOR_EVAL_MODE (rmp/mm)#60
Open
feat(vault): support configurable ENVECTOR_EVAL_MODE (rmp/mm)#60
Conversation
…ar (#59) Hardcoded eval_mode="rmp" in vault_core.py prevented connecting to envector-msa >= 1.4.0 which uses MM (Multi-Multiplication) mode. Read eval mode from ENVECTOR_EVAL_MODE env var (default: rmp for backward compat with envector.io cloud / 1.2.x deployments). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Raise ValueError at startup if ENVECTOR_EVAL_MODE is not one of the
supported values {"rmp", "mm"}, so misconfiguration fails fast with a
clear message instead of propagating an opaque SDK error.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…59) Remove cloud/deployment-type framing in favor of version-based guidance, which stays accurate as envector-msa versions evolve. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
After envector version v1.4.0, we cannot choose the |
|
As Junghwad said + AFAIK, there is no more 'rmp' mode. mm only. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ecurity (#59) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
eval_mode was hardcoded to "rmp" in vault_core.py, blocking users on envector-msa ≥ 1.4.0-alpha which requires "mm" mode. Invalid values also silently propagated to the SDK with an opaque error.
TL;DR
Make FHE eval mode configurable via ENVECTOR_EVAL_MODE env var, with startup-time validation.
Summary
vault_core.py: read ENVECTOR_EVAL_MODE env var (default "rmp"), validate against allowlist {"rmp", "mm"} in ensure_vault() — invalid values raise ValueError with a clear message at startupdocker-compose.yml: expose ENVECTOR_EVAL_MODE=${ENVECTOR_EVAL_MODE:-rmp} to the container.env.example: document rmp vs mm difference and the key-regeneration requirementtests/unit/test_eval_mode.py: 7 unit tests covering env var reading, ev.init() call args, and allowlist guard behaviorAlternatives
Test plan