Commit 8574aa5
fix(go): apply Phase A review feedback + slim progress doc
Reviewer A (Go 코드 품질) Critical 2 + Major 다수:
- isNormalShutdown dead branch 제거 (nil || ctx.Canceled 만)
- stubHandler 가 *Deps 캡처 (8 call site 시그니처 통일)
- Register 가 error 반환 + defer recover() (AddTool panic 가드)
- log.Printf → slog.Error
- go.mod toolchain go1.25.0 directive
- Deps ghost field 제거 → 빈 struct + 향후 sketch 코멘트
Reviewer B (설계/문서) Major 8 — doc 정확도:
- LOC 정정 (main.go 80→74, tools.go 137→134)
- §1.5 code block runnable + topk non-nullable 정정
- §2.2 absolute path placeholder + namespace 충돌 설명
- §4.7 macOS bash 3.2 coproc 경고
- §7 다음 마일스톤 11개로 확장
phase-a-mcp-boot.md 슬림화 (588→180줄):
- F1~F6 narrative → 동작/한계 매트릭스
- §3 Level 1.1~1.6 6 시퀀스 → 핵심 3 블록 (build/list/call)
- §4 cookbook 8 subsection → mcp_call 헬퍼 + 8 tool 호출 1 블록
- §6 코드 변경 요약 삭제 (git diff에 있음)
검증: go build · go vet · smoke test (initialize → tools/list 8 → tools/call) ✅
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent b5e2c9b commit 8574aa5
6 files changed
Lines changed: 165 additions & 538 deletions
File tree
- cmd/rune-mcp
- docs/v04
- notes
- progress
- internal/mcp
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
21 | 20 | | |
22 | 21 | | |
23 | | - | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
| |||
56 | 54 | | |
57 | 55 | | |
58 | 56 | | |
59 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | | - | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
71 | 72 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
| 73 | + | |
81 | 74 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
78 | 80 | | |
79 | 81 | | |
80 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
38 | 41 | | |
39 | 42 | | |
40 | 43 | | |
| |||
0 commit comments