feat: 2fa auth#1343
Open
MrWeez wants to merge 48 commits into
Open
Conversation
Open
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…trollers and extensions
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 54 out of 55 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
themes/BlueInfinity/views/layouts/app.blade.php:40
- Like the main layout, the BlueInfinity auth layout doesn’t include
@stack('modals')/@stack('scripts')and doesn’t respect$suppressSweetAlert2. Since the new 2FA auth views extendlayouts.app, this can lead to inconsistent behavior between themes (and makes it hard for extensions to inject scripts/modals consistently). Consider aligning this layout with the default theme’slayouts/app.blade.phpchanges (stacks + SweetAlert suppression guard).
Comment on lines
17
to
22
| content='{{ \Illuminate\Support\Facades\Storage::disk('public')->exists('logo.png') ? asset('storage/logo.png') : asset('images/ctrlpanel_logo.png') }}' | ||
| property="og:image"> | ||
| <title>{{ config('app.name', 'Laravel') }}</title> | ||
| <title>{{ config('app.name', 'CtrlPanel.gg') }}</title> | ||
| <link rel="icon" | ||
| href="{{ \Illuminate\Support\Facades\Storage::disk('public')->exists('favicon.ico') ? asset('storage/favicon.ico') : asset('favicon.ico') }}" | ||
| type="image/x-icon"> |
Collaborator
Author
There was a problem hiding this comment.
Blueinfinity is fucked up. That's not the only it's problem. It's completely out-of-sync from default theme. Needs to be fixed with another PR
…d full structure map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces very important security feature - 2FA authentication. Users asked for this feature for a very long time, since it greatly improves security for both admins and regular users.
Implementation is very flexible and made using extensions. Any new 2FA method can be added without touching core files, just by placing 2FA method directory inside
/app/Extensions/TwoFactor/.Theme developers is able to override 2FA method provided views. For more information read
app/Extensions/TwoFactor/THEMING.mdCurrently it includes only default TOTP method, but more optio will be added in the feature.
It also improves UI/UX of profile page and adds support for custom views for Extensions
Closes #758
Type of Change
Testing
Tested all possible scenarios. Enable, disable and action. All login process and related functions
Screenshots
AI Assistance
Checklist
developmentbranchLegal
By submitting this pull request, I confirm that my contribution is made
under the terms of the project's
Contributor License Agreement
and that I have read and agree to the
Code of Conduct.