DeviceInfo: Don't block map tiles when reachability is Unknown#63
Merged
Conversation
isInternetAvailable() required QNetworkInformation::reachability() to be exactly Online. On Qt 6.6.3/Android the reachability stays Unknown for a connection established before the app started, so every map tile fetch was short-circuited with 'Network Not Available' and no request was ever made, even though the network was fully validated and other requests (e.g. version checks) worked. Treat only a definite Disconnected as offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isInternetAvailable() required QNetworkInformation::reachability() to be exactly Online. On Qt 6.6.3/Android the reachability stays Unknown for a connection established before the app started, so every map tile fetch was short-circuited with 'Network Not Available' and no request was ever made, even though the network was fully validated and other requests (e.g. version checks) worked. Treat only a definite Disconnected as offline.