Skip to content

Commit a7beb2d

Browse files
committed
contributors!
1 parent d0c72cd commit a7beb2d

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

CONTRIBUTING.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ You're free to fork our repository and [open a pull request](../../pulls/) if yo
66

77
Before opening or marking your pull request as ready for review, please be sure to test your build and make sure it is stable and not conflicting with the upstream repository. Try not to diverge from our current code styling and practices in your fork.
88

9+
### Practices
10+
The things you should always do and not do when opening a new pull request.
11+
- **Be clear!** Explain the important details of your changes, if not already obvious.
12+
- **Don't change versioning metadata.** Our maintainers will do that once it's been decided a new update should release soon.
13+
- **Don't write changelogs.** Maintainers will check back on changes and document everything!
14+
- **Isolate your changes.** Refrain from formatting or changing code outside of what you're actually working on to prevent conflicts.
15+
- **Get ready for feedback!** Sometimes not everything done does not meet the standard or is just questionable.
16+
917
### Guidelines
1018
This section mainly covers contributions for new features to Horrible Menu. For other pull requests, we simply ask that you justify your changes in detail when opening your request.
1119

src/hooks/obstructive/FakeDeath.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class $modify(FakeDeathPlayLayer, PlayLayer) {
2020
HORRIBLE_DELEGATE_HOOKS(THIS_ID);
2121

2222
void destroyPlayer(PlayerObject* player, GameObject* game) {
23-
if (game == m_anticheatSpike && player && !player->m_isDead) return PlayLayer::destroyPlayer(player, game);
23+
if (game == m_anticheatSpike && !player->m_isDead) return PlayLayer::destroyPlayer(player, game);
2424

2525
sfx::play(sfx::file::bad);
2626
GJBaseGameLayer::shakeCamera(1.f, 2.f, 1.f);

0 commit comments

Comments
 (0)