Skip to content

Commit d68df81

Browse files
realmarcinclaude
andcommitted
Address Copilot review on PR #89
Three findings, all addressed: - Path globs: \`**.py\` doesn't actually match nested subdirs in GitHub Actions glob semantics — it behaves like \`*.py\`. Switch to \`**/*.py\` so changes under src/communitymech/<subpkg>/ (like network/, validators/, embedding/) trigger the workflow. - Push trigger had no \`paths:\` filter, so the workflow ran on every commit to main. Mirror the pull_request path list via a YAML anchor (&trigger_paths + *trigger_paths) so the two stay in sync. - uv sync: switch to \`--frozen --all-extras\` so the workflow fails if uv.lock is stale (instead of silently re-resolving) while keeping the dev/test extras the existing network-quality.yml uses. Also added uv.lock + tests/**/*.py to the trigger paths so dependency and test changes re-run the workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 62e0a8c commit d68df81

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

.github/workflows/validate-strict.yaml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,19 @@ name: validate-strict
22

33
on:
44
pull_request:
5-
paths:
5+
paths: &trigger_paths
66
- "kb/communities/**"
77
- "src/communitymech/schema/**"
8-
- "src/communitymech/**.py"
9-
- "scripts/**.py"
8+
- "src/communitymech/**/*.py"
9+
- "scripts/**/*.py"
10+
- "tests/**/*.py"
1011
- "justfile"
1112
- "pyproject.toml"
13+
- "uv.lock"
1214
- ".github/workflows/validate-strict.yaml"
1315
push:
1416
branches: [main]
17+
paths: *trigger_paths
1518
workflow_dispatch:
1619

1720
permissions:
@@ -37,7 +40,11 @@ jobs:
3740
enable-cache: true
3841

3942
- name: Install dependencies
40-
run: uv sync --all-extras
43+
# --frozen fails the workflow if uv.lock is stale (don't silently
44+
# re-resolve in CI). --all-extras keeps parity with the existing
45+
# network-quality.yml workflow and ensures pytest + optional deps
46+
# are available for the test step below.
47+
run: uv sync --frozen --all-extras
4148

4249
- name: Run validate-strict (closed-schema LinkML validation)
4350
run: just validate-strict

0 commit comments

Comments
 (0)