Chlorobium chlorochromatii CaD3: g__ genus fallback instead of null gtdb_id#201
Merged
Merged
Conversation
…b_id The only remaining null gtdb_id/gtdb_taxon block in the KB. The lineage already resolves to g__Chlorobium (majority_fraction 1.0), so ground the strain-level NCBI taxon (NCBITaxon:340177) at genus rank — matching the skill's genus-fallback convention used elsewhere (e.g. AMD_Nitrososphaerota GTDB:g__Nitrososphaera) — rather than leaving id/taxon null. Species-level GTDB has no representative for strain CaD3; noted in mapping_source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up tidy-up flagged during the #185 review.
Chlorochromatium_Aggregatum_Phototrophic_Consortium.yamlheld the KB's onlygtdb_classificationblock withgtdb_id: null/gtdb_taxon: null, even though itsgtdb_lineagealready resolved tog__Chlorobium(majority_fraction 1.0).This grounds the strain-level NCBI taxon (
NCBITaxon:340177, Chlorobium chlorochromatii CaD3) at genus rank —GTDB:g__Chlorobium/Chlorobium— matching the skill's genus-fallback convention used elsewhere (e.g.AMD_Nitrososphaerota→GTDB:g__Nitrososphaera). Species-level GTDB has no representative for strain CaD3; that's noted inmapping_source. Uses only data already present in the block (no new grounding invented).linkml-validatepasses; 0 null-gtdb_idblocks remain KB-wide.🤖 Generated with Claude Code