Merge pull request #6 from Cyber-Syntax:feat/xdg-base-dir

refactor: use xdg base dir for config files

Author: Cyber-Syntax

CHANGELOG.md

@@ -1,6 +1,15 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## v0.2.2-alpha
+### BREAKING CHANGES
+- Users need to setup their config with script and change according to
+their needs
+
+### Changed
+    - fix: redundant code
+    - refactor!: use XDG Base Directory
+    
 ## v0.2.1-alpha
 ### Changed
   - Add github action for release
@@ -15,6 +24,6 @@ All notable changes to this project will be documented in this file.
 
 ## v0.1.0-alpha
 ### What's Changed
-  - Feat/laptop desktop by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/1
+  - Feat/laptop desktop by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/2
   - fix: wrong way to write grub file by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/2
   - Initial setup script for Fedora

README.md

@@ -12,8 +12,11 @@ Basically, saving time. Also, I enjoy scripting and wrote this in bash for learn
 # How to use the script
 
 1. Please change the variables as your system configuration:
-   - variables.sh
+   - ~/.config/fedora-setup/variables.json
+   - ~/.config/fedora-setup/packages.json
+2. Config files according to your system configuration:
    - src/configs/01-mytlp.conf
+   - src/configs/99-qtile.rules
 
 ```bash
 WARNING:

setup.sh

@@ -8,26 +8,18 @@
 set -euo pipefail
 IFS=$'\n\t'
 
-# Source additional functions from separate files.
+#!/usr/bin/env bash
+
+# Setup XDG Base Directory paths if not already set
+XDG_CONFIG_HOME="${XDG_CONFIG_HOME:-$HOME/.config}"
+
 source src/logging.sh
-source src/variables.sh
-source src/packages.sh
+source src/config.sh
 source src/general.sh
 source src/apps.sh
 source src/desktop.sh
 source src/laptop.sh
 
-echo "=================================================="
-echo "important: this script uses configuration values from src/variables.sh"
-echo "please ensure you've reviewed and adjusted these values for your system."
-echo "=================================================="
-#TODO: better way to check and notify user to prevent variable errors.
-read -p "Have you reviewed src/variables.sh? (y/n): " user_confirmed
-if [[ "${user_confirmed,,}" != "y" ]]; then
-  log_warn "Please review src/variables.sh before running this script."
-  exit 1
-fi
-
 # Help message
 usage() {
   cat <<EOF