Refactor: separate estimators into separate files#67
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the __init__.py file by extracting classes into separate modules to improve code organization and maintainability.
- Moves base class and concrete estimator implementations to dedicated modules
- Creates separate files for stratified, simple, and local distribution estimators
- Simplifies the main
__init__.pyto focus on imports and exports
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
dte_adj/__init__.py |
Refactored to import classes from separate modules instead of defining them inline |
dte_adj/base.py |
Contains the base DistributionEstimatorBase abstract class with common functionality |
dte_adj/stratified.py |
Contains stratified distribution estimator implementations |
dte_adj/simple.py |
Contains simple distribution estimator implementations that inherit from stratified classes |
dte_adj/local.py |
Contains local distribution estimator implementations for LDTE and LPTE |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the init.py and separate the contents into multiple files