Replace assert-based genre validation with ValueError in names.py and voice.py

[Copilot]

assert statements used for import-time genre coverage validation in names.py and voice.py are silently compiled out under python -O, allowing unmapped genres to pass through without error—causing fallback to "contemporary" name pools or unweighted voice selection.

Changes

• novelforge/names.py / novelforge/voice.py: Replace assert not _missing_*_genres with explicit if guards that raise ValueError, unconditionally enforced regardless of optimization flags:

# Before
assert not _missing_name_genres, (
    f"Genres missing from _GENRE_GROUP in names.py: {sorted(_missing_name_genres)}. ..."
)

# After
if _missing_name_genres:
    raise ValueError(
        f"Genres missing from _GENRE_GROUP in names.py: {sorted(_missing_name_genres)}. ..."
    )

• tests/test_names.py / tests/test_voice.py: Add TestNameGenreValidation / TestVoiceGenreValidation classes that use importlib.reload + monkeypatch to verify ValueError is raised when a genre is absent from the mapping, and that no error occurs when coverage is complete.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• api.openai.com
  • Triggering command: /usr/bin/python python -m pytest --tb=short -q --cov=. --cov-report=term-missing --cov-fail-under=85 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR makes genre→mapping coverage checks in novelforge/names.py and novelforge/voice.py robust under python -O by replacing assert-based import-time validation with unconditional ValueError guards, and adds tests to confirm the behavior via importlib.reload().

Changes:

• Replace assert not _missing_*_genres with if _missing_*_genres: raise ValueError(...) in names.py and voice.py.
• Add reload-based tests that monkeypatch novelforge.validation.ALLOWED_GENRES to simulate missing coverage and assert a ValueError is raised.
• Add “no error when coverage is complete” reload tests for both modules.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
novelforge/names.py	Switch import-time genre coverage validation from assert to ValueError to avoid -O silencing.
novelforge/voice.py	Same as above for voice-weight genre coverage.
tests/test_names.py	Add reload-based tests to ensure missing genre coverage raises ValueError.
tests/test_voice.py	Add reload-based tests to ensure missing genre coverage raises ValueError.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The failing importlib.reload(novelforge.names) leaves novelforge.names in a partially re-executed state for the remainder of the test session (reload reuses the existing module dict and does not roll back on exceptions). That can create order-dependent behavior if any later test imports/uses novelforge.names expecting a clean module state. Consider reloading the module back to a known-good state in a finally block (after restoring ALLOWED_GENRES) or using a fixture that always reloads novelforge.names with the standard ALLOWED_GENRES after this test.

Suggested change

	extended = novelforge.validation.ALLOWED_GENRES | {"FakeGenreForTest"}
	monkeypatch.setattr(novelforge.validation, "ALLOWED_GENRES", extended)
	with pytest.raises(ValueError, match="FakeGenreForTest"):
	original_allowed_genres = novelforge.validation.ALLOWED_GENRES
	extended = original_allowed_genres | {"FakeGenreForTest"}
	monkeypatch.setattr(novelforge.validation, "ALLOWED_GENRES", extended)
	try:
	with pytest.raises(ValueError, match="FakeGenreForTest"):
	importlib.reload(novelforge.names)
	finally:
	monkeypatch.setattr(
	novelforge.validation,
	"ALLOWED_GENRES",
	original_allowed_genres,
	)

[Copilot]

Similar to names.py: when importlib.reload(novelforge.voice) raises, the module is left partially re-executed (no rollback), which can leak state into later tests and make outcomes order-dependent. It’s safer to restore a clean module state after the assertion (e.g., reload again after monkeypatch is undone, or wrap the reload in try/except + finally that reloads with the original ALLOWED_GENRES).

Suggested change

	extended = novelforge.validation.ALLOWED_GENRES | {"FakeGenreForTest"}
	monkeypatch.setattr(novelforge.validation, "ALLOWED_GENRES", extended)
	with pytest.raises(ValueError, match="FakeGenreForTest"):
	original_allowed_genres = novelforge.validation.ALLOWED_GENRES
	extended = original_allowed_genres | {"FakeGenreForTest"}
	monkeypatch.setattr(novelforge.validation, "ALLOWED_GENRES", extended)
	try:
	with pytest.raises(ValueError, match="FakeGenreForTest"):
	importlib.reload(novelforge.voice)
	finally:
	monkeypatch.setattr(
	novelforge.validation, "ALLOWED_GENRES", original_allowed_genres
	)