Commit 3f3aede
committed
Fix CI failures from the HDR export deps
The HDR encoders pulled in build-time native requirements that the CI
matrix couldn't satisfy, breaking clippy and every x86_64/Windows-arm
build job (ARM Linux and Apple Silicon happened to pass).
rav1e "asm" feature
Needs nasm at build time on x86_64 (missing on the Ubuntu/macOS-intel
runners) and fails to link on aarch64-pc-windows-msvc (LNK1181). Drop
it for a pure-Rust encode: builds everywhere with no system deps, which
also matches the "no C/system deps" promise in the comment. Cargo.lock
loses nasm-rs/cc accordingly.
clippy --all-features
--all-features enabled the optional hdr_jxl feature, which links system
libjxl (>= 0.11.2); the Ubuntu runners only ship far older libjxl, so
the job died compiling jpegxl-sys. Lint the default feature set instead,
which matches what the release builds actually compile.
Windows MSI version error
The matrix sets `builds-args: --bundles nsis`, but the reusable workflow
reads `matrix.args`, so the flag was never passed and tauri also built an
MSI bundle — which rejects the non-numeric `1.5.7-hdr` pre-release. Read
`matrix.builds-args` (falling back to `matrix.args` for the Android row)
so Windows builds NSIS only, as intended; the MSI was never uploaded
anyway (the artifact step only collects *.exe).
New clippy findings that surfaced once clippy could reach the crate:
- removed a dead `MAX_MASK_BINDINGS` const added to GpuProcessor::new
- #[allow(too_many_arguments)] on GpuProcessor::run (now 8 args w/ output_hdr)
- #[allow(field_reassign_with_default)] on encode_avif_hdr (rav1e idiom)1 parent 93edcc3 commit 3f3aede
8 files changed
Lines changed: 14 additions & 19 deletions
File tree
- .github/workflows
- src-tauri
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
74 | 76 | | |
75 | 77 | | |
76 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
761 | 761 | | |
762 | 762 | | |
763 | 763 | | |
764 | | - | |
765 | 764 | | |
766 | 765 | | |
767 | 766 | | |
| |||
1166 | 1165 | | |
1167 | 1166 | | |
1168 | 1167 | | |
| 1168 | + | |
1169 | 1169 | | |
1170 | 1170 | | |
1171 | 1171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
654 | 654 | | |
655 | 655 | | |
656 | 656 | | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
657 | 660 | | |
658 | 661 | | |
659 | 662 | | |
| |||
0 commit comments