Commit 97fa495
committed
fix: VC guard on filmstripActivePath, pickPrimary default case, cleanup
Issues found during code review:
- filmstripActivePath was missing the is_virtual_copy guard that
variantOptions already had. A VC of a grouped file would highlight
the group primary in the filmstrip instead of itself.
- pickPrimary switch had no default case. A corrupt settings file
sending an unknown preference string would return undefined.
- Use Set for extension dedup in groupBadgeInfo (was indexOf loop).
- Add skip_serializing to deprecated group_associated_files so it
stops being written back to the settings file.
- Remove stale comment.1 parent a9e7a81 commit 97fa495
3 files changed
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
399 | 399 | | |
400 | 400 | | |
401 | 401 | | |
402 | | - | |
| 402 | + | |
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1050 | 1050 | | |
1051 | 1051 | | |
1052 | 1052 | | |
1053 | | - | |
1054 | 1053 | | |
1055 | 1054 | | |
1056 | 1055 | | |
1057 | 1056 | | |
1058 | 1057 | | |
1059 | | - | |
1060 | | - | |
1061 | | - | |
| 1058 | + | |
1062 | 1059 | | |
1063 | 1060 | | |
1064 | 1061 | | |
| |||
1087 | 1084 | | |
1088 | 1085 | | |
1089 | 1086 | | |
1090 | | - | |
| 1087 | + | |
1091 | 1088 | | |
1092 | 1089 | | |
1093 | 1090 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
| 81 | + | |
80 | 82 | | |
81 | 83 | | |
82 | 84 | | |
| |||
0 commit comments