Add Ctrl+Up/Down shortcuts for brush size adjustment in masks panel#946
Conversation
|
Thanks so much for this! If possible, can you also make that pressing shift turns the brush into the negative (eraser) brush? |
Well it will be a lil hard to do it now, cause just found a little bug, gotta correct that first. After that, I will surely try. |
|
Well just discovered that the bug wasn't created by my PR, It was still there before it, although it has been solved to a significant extent, It was basically a bug with zoom and shortcuts for zoom, but it has been fixed now (at least that's what I think), Regards, |
Are we talking about the arrow up / down zoom bug? I also just noticed and it's not related to your PR. But... it's also not fixed in your PR. I think you can safely undo the last commit (which changes the zoom logic) and just push the actual PR / ctrl up + ctrl down shortcuts for brush size (and maybe shift for negative brush). We can track the other bug later :) |
|
Sorry For Late Response, @CyberTimon . Sure, why not, 😁. BTW I Updated The Color Grading PR With Tone Curves' Like Tabs UI And A 5th Tab Featuring All Wheels, So If You Don't Mind, Please Take A Look On That Too. Regards, |
If you are saying this because of the video, then I would like to inform you that that bug was fixed after the video was recorded. So it's not reflected there, I will make a video with the updated zoom arrows ASAP. Thanks for the feedback, @CyberTimon . Regards, |
|
On my phone rn, but I actually tested the changes (pulled from git). I can retest tomorrow, maybe I did something wrong on my end.. ;) |
|
Sure, and if the problem still persists do tell me, I will try my best to fix it, Regards, |
|
Hi @CyberTimon , I found that Shift while using brush mask is already in use to create straight (not curly (like hand-drawn)) lines, BTW I just checked the zoom bug, and it's fixed now,
You can test on your device too, and if there's still an issue, do inform me. |
|
Hi @CyberTimon,
Keep in mind that in order for it to function as expected you will first have to release the touchpad and then release Alt.
The PR is now open for you to review |
|
@mmadesignerunknown Thank you implementing all this :D Just one thing, Screencast.from.2026-03-31.16-35-25.mp4When holding down ALT and erasing, then letting go of ALT it switches back to the Brush. Personally I don't really like this behavior, not sure about other people tho. I would either want the eraser to stay erasing for the whole brush stroke or even better, only apply the eraser to that part of the brush stroke and after the user stops holding down the ALT key, it's brushing again. (The second one would be harder to implement tho, I think). What do you think about this? Everything else seems to work perfectly as expected. And while we are at it, do you think you could fix this too? #910 |
|
Hi @Duecki1 , Thanks For Reviewing And Giving Feedback, I also faced the problem you are facing and even tried to address that, but unfortunately I am not a developer and eventually messed up, so as of current PR everything will work as expected ONLY IF (touchpad in my case) is released before releasing the Alt button. I will try again to fix this, but actually got an exam tomorrow so can't manage the time today, I will probably look into it the day after or something like that. Hopefully, we will be able to fix it. As of this PR's current state, the workflow will be (Touchpad In My Case):
Thanks alot, (Sorry for bad English, not my native language 🥲) |
Thank you, If I find time, I will take a look at it too :). Good luck with your exam tomorrow. And your English is not bad (mine is xD). Linus |
Sure, will look into that once I am done with my exams 😁. And if you don't mind, can you please review the pull request I made about the color grading panel here #939 , would appreciate if you can. |
Thanks 😁. |
|
Yups I like the idea, will look into it too,😁 |
Thank you too for implementing this much :D |
|
No Need 😅. |
|
I just made a commit for feather size in brush cursor, on mobile RN so can't check if it's working correctly or not, if you are on desktop, can you please check. I would appreciate the effort 😁. (The code was AI generated but guided by a human) |
I can't check rn sadly. But I will do later. Thank you :) |
|
I just checked it, although it doesn't create a gradient like the mask preview (I tried to impelment it but it threw errors, IDK why) But It now has, an inner core, and an outer circle (for feather value), to give some sort of a visual hint. |
|
Thanks for trying to implement a visualized feather effect, but lets track this in a seperate PR. I don't like the current vibecoded way. Please undo these commits :) The rest looks very good. Can we maybe also make that ctrl (or shift?)+ scroll changes the brush size? What do you guys think? |
|
Thanks for the response, @CyberTimon , Sure, why not, I will undo these changes, sorry for the disappointment though.😅 As far as you are concerned about the shortcuts, the brush mask has these shortcuts as per the current PR.
IMO, These are enough. |
cdc0e5d to
3c23a87
Compare
|
I have reverted the feather preview changes @CyberTimon . |
|
The shortcuts sound 'spot on!' - it might be nice to have a visual brush size change popping up (somewhere obvious) when the slider is moved as well? |
|
Thanks for the feedback @taigenetsudo-code , I will look into this for sure, and if you have any other suggestions, please inform about them too. Thanks. Regards, |
|
Thanks @mmadesignerunknown for your work! I've just tested it and it looks good to me. Other improvements can be tracked in another PR 👌. I will merge this now, as v1.5.3 is releasing soon. |
|
Thanks alot @CyberTimon for accepting the contribution. 😁 |
|
Can't wait to try out....😁 |
|
I'm doing some final testing and then I will release v1.5.3 💯 |
|
Hi @CyberTimon , Although I am really looking forward to the release, it will be great of you could review the pull request here too #939 and implement it before the new release. I hope you won't get annoyed, Thanks, Regards, |
|
Thanks for the note. I will review it after my holidays and push it into the next release (v1.5.4). Version v1.5.3 is already out now ;) Have a nice evening, |
|
Thank you @CyberTimon . Have a nice holiday. |





Description
Adds keyboard shortcuts to adjust brush size while using the masks panel, making brush size adjustment faster and more intuitive during masking operations.
Currently, users need to manually drag the brush size slider. This PR adds keyboard shortcuts for quicker adjustment.
Type of Change
Changes Made
brushSettingsprops touseKeyboardShortcutshookarrowup/arrowdowncases in Ctrl blockScreenshots/Videos
https://streamable.com/armg87 (uploaded because of size issue, it will expire in 2 days, once again, sorry for the inconvenience @CyberTimon.)
Testing
Test Configuration:
Checklist
Additional Notes
AI Disclaimer:
Please state the involvement of AI in this PR: