Skip to content

Fix/filmstrip multiselect anchor#965

Merged
CyberTimon merged 1 commit intoCyberTimon:mainfrom
savukadoo:fix/filmstrip-multiselect-anchor
Apr 7, 2026
Merged

Fix/filmstrip multiselect anchor#965
CyberTimon merged 1 commit intoCyberTimon:mainfrom
savukadoo:fix/filmstrip-multiselect-anchor

Conversation

@savukadoo
Copy link
Copy Markdown

Description

Fixes an issue where multi-range selection in the filmstrip incorrectly expanded into a single continuous range.

Type of Change

  • Bug fix

Changes Made

Previously:

  • Shift selections always anchored from the initial selection
  • Resulted in unintended selection of all items between first and last

Now:

  • Introduces a dedicated selection anchor
  • Supports proper additive multi-range selection (e.g. 1–2, 5–7, 9–11)

Screenshots/Videos

Screenshot 2026-04-04 at 08 28 29

Testing

  • I have tested these changes locally and confirmed that they work as expected without issues

Test Configuration:

  • OS: macOS Sonoma
  • Hardware: Apple M2

Checklist

  • My code follows the project's code style
  • I haven't added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

AI Disclaimer:

Please state the involvement of AI in this PR:

  • This PR is AI-generated but guided by a human

@savukadoo savukadoo requested a review from CyberTimon as a code owner April 3, 2026 22:28
@CyberTimon
Copy link
Copy Markdown
Owner

Thanks for the PR! Looks great. Can you remove the unrelated commit from the other PR? I will merge it then 💯 . Thanks for your contribution :)

@savukadoo savukadoo force-pushed the fix/filmstrip-multiselect-anchor branch from 47eb2aa to 1685f76 Compare April 4, 2026 20:27
@savukadoo
Copy link
Copy Markdown
Author

apologies, I have removed that unrelated PR and it should be cleaner now

@CyberTimon
Copy link
Copy Markdown
Owner

Thanks! Will merge now. Appreciate all your contributions 💯

@CyberTimon CyberTimon merged commit f5fbccd into CyberTimon:main Apr 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants