Update webhook service tests

Cyclenerd · Cyclenerd · commit 2625ef212c1f · 2026-05-18T17:57:47.000+02:00
diff --git a/tests/unit/test_webhook_service.py b/tests/unit/test_webhook_service.py
@@ -112,13 +112,13 @@ def test_handle_completed_job(self, mock_gh_client_class, mock_gc_client_class):
         payload = {
             'action': 'completed',
             'workflow_job': {
-                'runner_name': 'runner-12345'
+                'runner_name': 'gcp-runner-12345'
             }
         }
 
         service.handle_workflow_job(payload)
 
-        mock_gc_client.delete_runner_instance.assert_called_once_with('runner-12345')
+        mock_gc_client.delete_runner_instance.assert_called_once_with('gcp-runner-12345')
 
     @patch('app.services.webhook_service.GCloudClient')
     @patch('app.services.webhook_service.GitHubClient')
@@ -208,11 +208,11 @@ def test_handle_completed_job_with_error(self, mock_gh_client_class, mock_gc_cli
         payload = {
             'action': 'completed',
             'workflow_job': {
-                'runner_name': 'runner-12345'
+                'runner_name': 'gcp-runner-12345'
             }
         }
 
         # Should not raise exception, just log error
         service.handle_workflow_job(payload)
 
-        mock_gc_client.delete_runner_instance.assert_called_once_with('runner-12345')
+        mock_gc_client.delete_runner_instance.assert_called_once_with('gcp-runner-12345')

Original file line number	Diff line number	Diff line change
`@@ -112,13 +112,13 @@ def test_handle_completed_job(self, mock_gh_client_class, mock_gc_client_class):`
`112`	`112`	`payload = {`
`113`	`113`	`'action': 'completed',`
`114`	`114`	`'workflow_job': {`
`115`		`- 'runner_name': 'runner-12345'`
	`115`	`+ 'runner_name': 'gcp-runner-12345'`
`116`	`116`	`}`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`service.handle_workflow_job(payload)`
`120`	`120`
`121`		`- mock_gc_client.delete_runner_instance.assert_called_once_with('runner-12345')`
	`121`	`+ mock_gc_client.delete_runner_instance.assert_called_once_with('gcp-runner-12345')`
`122`	`122`
`123`	`123`	`@patch('app.services.webhook_service.GCloudClient')`
`124`	`124`	`@patch('app.services.webhook_service.GitHubClient')`
`@@ -208,11 +208,11 @@ def test_handle_completed_job_with_error(self, mock_gh_client_class, mock_gc_cli`
`208`	`208`	`payload = {`
`209`	`209`	`'action': 'completed',`
`210`	`210`	`'workflow_job': {`
`211`		`- 'runner_name': 'runner-12345'`
	`211`	`+ 'runner_name': 'gcp-runner-12345'`
`212`	`212`	`}`
`213`	`213`	`}`
`214`	`214`
`215`	`215`	`# Should not raise exception, just log error`
`216`	`216`	`service.handle_workflow_job(payload)`
`217`	`217`
`218`		`- mock_gc_client.delete_runner_instance.assert_called_once_with('runner-12345')`
	`218`	`+ mock_gc_client.delete_runner_instance.assert_called_once_with('gcp-runner-12345')`