Add built-in retry logic for Hetzner runner creation (fixes #8)#9
Closed
xgboosted wants to merge 4 commits into
Closed
Add built-in retry logic for Hetzner runner creation (fixes #8)#9xgboosted wants to merge 4 commits into
xgboosted wants to merge 4 commits into
Conversation
- Introduce `create_retries` and `create_retry_delay` inputs to control retry attempts and delay for runner creation failures - Update README with new inputs and retry logic explanation - Refactor action.sh for improved readability and to support retry mechanism
Clarify the action name by shortening it to 'Self-Hosted GitHub Actions Runner on Hetzner' for consistency and simplicity.
Clarify that the action is for Hetzner Cloud by updating the name field in action.yml. This helps distinguish it from other Hetzner services and improves discoverability.
Remove invisible BOM character from the shebang line to ensure proper script execution in Unix environments.
Owner
|
Thank you for your pull request. Please take a close look at CONTRIBUTING.md and update your work. You have deleted quite a lot and made unnecessary changes. We indent with tabs in Shell scripts. Do not delete comments. First removing the Word Cloud and then adding it again is also unnecessary. |
Contributor
Author
|
Thanks for pointing out the coding style issue. I will redo this with a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces built-in retry logic for the runner creation step, addressing issue #8.
I have tested it by releasing the Action in the GH Marketplace, it works fine.
Features
New Inputs
create_retries: Number of retry attempts for runner creation (default: 1)create_retry_delay: Delay in seconds between attempts (default: 10)Enhancements
Documentation
README.mdwith usage instructions and input documentation.Refactoring
action.shfor improved readability and maintainability.