Fix Codacy "issues"

Signed-off-by: Georg Rottensteiner <georg@georg-rottensteiner.de>

Author: GeorgRottensteiner

CycloneDX/Models/NugetInputModel.cs

@@ -15,12 +15,20 @@
 // SPDX-License-Identifier: Apache-2.0
 // Copyright (c) OWASP Foundation. All Rights Reserved.
 
+using System.Transactions;
+
 namespace CycloneDX.Models
 {
     public static class NugetInputFactory
     {
         public static NugetInputModel Create(string baseUrl, string baseUrlUserName, string baseUrlUserPassword,
-            bool isPasswordClearText, string feedName = "Unnamed Source" )
+            bool isPasswordClearText)
+        {
+            return Create(baseUrl, baseUrlUserName, baseUrlUserPassword, isPasswordClearText, "Unnamed Source");
+        }
+
+        public static NugetInputModel Create(string baseUrl, string baseUrlUserName, string baseUrlUserPassword,
+            bool isPasswordClearText, string feedName )
         {
             if (string.IsNullOrEmpty(baseUrl))
             {
@@ -57,7 +65,7 @@ public NugetInputModel(string baseUrl, string baseUrlUserName, string baseUrlUse
             nugetUsername = baseUrlUserName;
             nugetPassword = baseUrlUserPassword;
             IsPasswordClearText = isPasswordClearText;
-            nugetFeedName = nugetFeedName;
+            nugetFeedName = feedName;
         }
     }
 }

CycloneDX/Runner.cs

@@ -134,7 +134,7 @@ public async Task<int> HandleCommandAsync(RunOptions options)
             }
 
             var packages = new HashSet<DotnetDependency>();
-            var sources = new HashSet<NugetInputModel>();
+            HashSet<NugetInputModel> sources = null;
 
             // determine what we are analyzing and do the analysis
             var fullSolutionOrProjectFilePath = this.fileSystem.Path.GetFullPath(SolutionOrProjectFile);

CycloneDX/Services/NugetConfigFileService.cs

@@ -29,13 +29,13 @@ namespace CycloneDX.Services
 {
     public class NugetConfigFileService : INugetConfigFileService
     {
-        private XmlReaderSettings _xmlReaderSettings = new XmlReaderSettings 
+        private readonly XmlReaderSettings _xmlReaderSettings = new XmlReaderSettings 
         {
             Async = true
         };
 
-        private IFileSystem _fileSystem;
-        private FileDiscoveryService _fileDiscoveryService;
+        private readonly IFileSystem _fileSystem;
+        private readonly FileDiscoveryService _fileDiscoveryService;
 
         public NugetConfigFileService(IFileSystem fileSystem)
         {

CycloneDX/Services/NugetV3Service.cs

@@ -40,6 +40,15 @@ namespace CycloneDX.Services
     /// </summary>
     public class NugetV3Service : INugetService
     {
+        public class PackageNotFoundException : Exception
+        {
+            public PackageNotFoundException(string message) : base(message) { }
+
+            public PackageNotFoundException(string message, Exception innerException) : base(message, innerException) { }
+        }
+
+
+
         private readonly List<SourceRepository> _sourceRepositories;
         private readonly SourceCacheContext _sourceCacheContext;
         private readonly CancellationToken _cancellationToken;
@@ -360,7 +369,7 @@ await resource.CopyNupkgToStreamAsync(name, packageVersion, packageStream, _sour
                 }
                 if (!foundResource)
                 {
-                    throw new Exception( $"Did not find package {name} {version}");
+                    throw new PackageNotFoundException( $"Did not find package {name} {version}");
                 }
 
                 using PackageArchiveReader packageReader = new PackageArchiveReader(packageStream);