tests

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

Author: jkowalleck

src/factories/fromNodePackageJson.node.ts

@@ -112,27 +112,20 @@ export class ExternalReferenceFactory {
     const { tarball, integrity, shasum } = data.dist ?? {}
     if (typeof tarball === 'string') {
       const hashes = new HashDictionary()
-      const hashSources = []
+      let comment = 'as detected from PackageJson property "dist.tarball"'
       if (typeof integrity === 'string') {
         try {
           // actually not the hash of the file, but more of an integrity-check -- lets use it anyway.
           // see https://blog.npmjs.org/post/172999548390/new-pgp-machinery
           hashes.set(...parsePackageIntegrity(integrity))
-          hashSources.push(' and property "dist.integrity"')
+          comment += ' and property "dist.integrity"'
         } catch { /* pass */ }
       }
       if (typeof shasum === 'string' && shasum.length === 40) {
         hashes.set(HashAlgorithm["SHA-1"], shasum)
-        hashSources.push(' and property "dist.shasum"')
+        comment += ' and property "dist.shasum"'
       }
-      return new ExternalReference(
-        tarball,
-        ExternalReferenceType.Distribution,
-        {
-          hashes,
-          comment: `as detected from PackageJson property "dist.tarball"${hashSources.join('')}`
-        }
-      )
+      return new ExternalReference(tarball, ExternalReferenceType.Distribution, { hashes, comment })
     }
     return undefined
   }

tests/integration/Factories.FromNodePackageJson.ExternalReferenceFactory.test.js

@@ -97,6 +97,7 @@ suite('integration: Factories.FromNodePackageJson.ExternalReferenceFactory', ()
       assert.strictEqual(actual.length, 0)
     })
   })
+
   suite('from "repository"', () => {
     test('non-empty string', () => {
       const expected = [new ExternalReference(
@@ -267,4 +268,38 @@ suite('integration: Factories.FromNodePackageJson.ExternalReferenceFactory', ()
       assert.deepEqual(actual, expected)
     })
   })
+
+
+})
+
+suite('integration: Factories.FromNodePackageJson.ExternalReferenceFactory', () => {
+  const factory = new ExternalReferenceFactory()
+
+  const cases = {
+    makeVcs: [
+      // TODO
+    ],
+    makeHomepage: [
+      // TODO
+    ],
+    makeIssueTracker: [
+      // TODO
+    ],
+    makeDist: [
+      // TODO
+    ],
+  }
+  cases.makeExternalReferences = [
+    // TODO
+  ]
+  for (const [func, testData] of Object.entries(cases)) {
+    suite(func, () => {
+      for (const [label, data, expected] of testData) {
+        test(label, () => {
+          const actual = factory[func](data)
+          assert.deepStrictEqual(actual, expected)
+        })
+      }
+    })
+  }
 })

tests/unit/Factories.FromNodePackageJson.PackageUrlFactory.js

@@ -22,17 +22,11 @@ const assert = require('node:assert')
 const { suite, test } = require('mocha')
 
 const {
-  Factories: { FromNodePackageJson: {
-    ExternalReferenceFactory, PackageUrlFactory
-  }},
+  Factories: { FromNodePackageJson: { PackageUrlFactory }},
   Enums: { ComponentType, ExternalReferenceType },
   Models: { Component, ExternalReference, ExternalReferenceRepository }
 } = require('../../')
 
-suite('unit: Factories.FromNodePackageJson.ExternalReferenceFactory', () => {
-  // TODO
-})
-
 suite('unit: Factories.FromNodePackageJson.PackageUrlFactory', () => {
   suite('makeFromComponent()', () => {
     test('plain', () => {