feat: split tools#71
Conversation
| Editing the `tools.json` file manually can be complicated. An alternative is to use | ||
| [MetaConfigurator](https://metaconfigurator.github.io/meta-configurator/?schema=https://raw.githubusercontent.com/CycloneDX/tool-center/refs/heads/main/tools.schema.json&data=https://raw.githubusercontent.com/CycloneDX/tool-center/refs/heads/main/tools.json&settings=https://raw.githubusercontent.com/CycloneDX/tool-center/refs/heads/main/metaConfiguratorSettings.json) to make changes then download the edited data. | ||
| Creating/editing a file in the `tools/` folder manually can be complicated. An alternative is to use | ||
| [MetaConfigurator](https://www.metaconfigurator.org?schema=https://raw.githubusercontent.com/CycloneDX/tool-center/refs/heads/main/schemas/tool.schema.json&settings=https://raw.githubusercontent.com/CycloneDX/tool-center/refs/heads/main/metaConfiguratorSettings.json) to make changes then download the edited data. |
There was a problem hiding this comment.
207d2d9 to
ffee523
Compare
stevespringett
left a comment
There was a problem hiding this comment.
Overall I think this looks good. However, we may need to change where the Cloudflare Hook is executed. The idea is that whenever tools.json is updated, it will rebuild the public website. That process is now handled in assemble_tools_json.yml.
| uses: actions/deploy-pages@v4 | ||
|
|
||
| - name: Trigger Cloudflare Deploy Hook |
There was a problem hiding this comment.
I think we may need to trigger Cloudflare Deploy hook iin the assemble_tools_json.yml instead.
There was a problem hiding this comment.
we have a cloudflare deploy hook in the docs - what does it actually do?
for the changes in tools.json - i would go with a scheduled task for this purpose.
this can be added in a different pullrequest.
PS:
There was a problem hiding this comment.
we have a cloudflare deploy hook in the docs - what does it actually do?
It triggers Cloudflare pages to checkout the website repo and tools.json and rebuild and redeploy the entire website. A scheduled task should be avoided as it will erroneously result in timestamps in sitemap.xml for a "changed" website when there were no actual changes made. I don't know if there are any SEO penalties for this or not, but I'd rather not find out.
There was a problem hiding this comment.
understood.
the publication is triggered via .github/workflows/publish_toolcenter.yml now .
aca0368 to
bb995f7
Compare
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
bb995f7 to
87e90ef
Compare
fixes #67
tool.schema.jsonwas createdtools.jsonwas split into individual files in thetools/foldertools/folder follows the newtool.schema.jsontools/foldertools.jsonbased on all files in thetools/foldertools.jsonresult:
tools.jsonfile