Skip to content

Commit c36e559

Browse files
committed
Show shifted tooltips in advanced tooltip mode
Required for CyclopsMC/IntegratedDynamics#1596
1 parent 8f998cd commit c36e559

5 files changed

Lines changed: 13 additions & 6 deletions

File tree

loader-common/src/main/java/org/cyclops/cyclopscore/helper/IL10NHelpers.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import net.minecraft.ChatFormatting;
44
import net.minecraft.network.chat.Component;
5+
import net.minecraft.world.item.TooltipFlag;
56

67
import java.util.function.Consumer;
78

@@ -22,6 +23,11 @@ public default String getInfoPrefix() {
2223

2324
public void addStatusInfo(Consumer<Component> tooltipAdder, boolean isEnabled, String statusPrefixKey);
2425

25-
public void addOptionalInfo(Consumer<Component> tooltipAdder, String prefix);
26+
@Deprecated // TODO: rm in next major
27+
public default void addOptionalInfo(Consumer<Component> tooltipAdder, String prefix) {
28+
addOptionalInfo(tooltipAdder, prefix, TooltipFlag.NORMAL);
29+
}
30+
31+
public void addOptionalInfo(Consumer<Component> tooltipAdder, String prefix, TooltipFlag tooltipFlag);
2632

2733
}

loader-common/src/main/java/org/cyclops/cyclopscore/helper/L10NHelpersCommon.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import net.minecraft.network.chat.Component;
66
import net.minecraft.network.chat.Style;
77
import net.minecraft.network.chat.TextColor;
8+
import net.minecraft.world.item.TooltipFlag;
89
import org.cyclops.cyclopscore.Reference;
910

1011
import java.util.Arrays;
@@ -43,10 +44,10 @@ public void addStatusInfo(Consumer<Component> tooltipAdder, boolean isEnabled, S
4344
}
4445

4546
@Override
46-
public void addOptionalInfo(Consumer<Component> tooltipAdder, String prefix) {
47+
public void addOptionalInfo(Consumer<Component> tooltipAdder, String prefix, TooltipFlag tooltipFlag) {
4748
String key = prefix + ".info";
4849
if (I18n.exists(key)) {
49-
if (modHelpers.getMinecraftClientHelpers().isShifted()) {
50+
if (tooltipFlag.isAdvanced() || modHelpers.getMinecraftClientHelpers().isShifted()) {
5051
String localized = localize(key);
5152
StringHelpers.splitLines(localized, getMaxTooltipLineLength(), getInfoPrefix())
5253
.stream()

loader-fabric/src/main/java/org/cyclops/cyclopscore/item/ItemInformationProviderFabric.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
public class ItemInformationProviderFabric extends ItemInformationProviderCommon {
1616
public static void onTooltip(ItemStack itemStack, Item.TooltipContext tooltipContext, TooltipFlag tooltipFlag, List<Component> lines) {
1717
if (ITEMS_INFO.contains(itemStack.getItem())) {
18-
CyclopsCoreFabric._instance.getModHelpers().getL10NHelpers().addOptionalInfo(lines::add, itemStack.getItem().getDescriptionId());
18+
CyclopsCoreFabric._instance.getModHelpers().getL10NHelpers().addOptionalInfo(lines::add, itemStack.getItem().getDescriptionId(), tooltipFlag);
1919
}
2020
}
2121
}

loader-forge/src/main/java/org/cyclops/cyclopscore/item/ItemInformationProviderForge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class ItemInformationProviderForge extends ItemInformationProviderCommon
1313
public static void onTooltip(ItemTooltipEvent event) {
1414
ItemStack itemStack = event.getItemStack();
1515
if (ITEMS_INFO.contains(itemStack.getItem())) {
16-
ModHelpersForge.INSTANCE.getL10NHelpers().addOptionalInfo(event.getToolTip()::add, itemStack.getItem().getDescriptionId());
16+
ModHelpersForge.INSTANCE.getL10NHelpers().addOptionalInfo(event.getToolTip()::add, itemStack.getItem().getDescriptionId(), event.getFlags());
1717
}
1818
}
1919

loader-neoforge/src/main/java/org/cyclops/cyclopscore/item/ItemInformationProviderNeoForge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class ItemInformationProviderNeoForge extends ItemInformationProviderComm
1313
public static void onTooltip(ItemTooltipEvent event) {
1414
ItemStack itemStack = event.getItemStack();
1515
if (ITEMS_INFO.contains(itemStack.getItem())) {
16-
ModHelpersNeoForge.INSTANCE.getL10NHelpers().addOptionalInfo(event.getToolTip()::add, itemStack.getItem().getDescriptionId());
16+
ModHelpersNeoForge.INSTANCE.getL10NHelpers().addOptionalInfo(event.getToolTip()::add, itemStack.getItem().getDescriptionId(), event.getFlags());
1717
}
1818
}
1919

0 commit comments

Comments
 (0)