Skip to content

Commit c3ef74d

Browse files
committed
Merge remote-tracking branch 'origin/master-1.21-lts' into master-1.21
2 parents e1a085f + 4ddee6b commit c3ef74d

6 files changed

Lines changed: 71 additions & 6 deletions

File tree

.github/workflows/copilot-setup-steps.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ jobs:
4545
- name: 'Build'
4646
run: ./gradlew build --no-daemon
4747
env:
48-
MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
49-
MAVEN_KEY: ${{ secrets.MAVEN_KEY }}
48+
MAVEN_USERNAME: ${{ github.actor }}
49+
MAVEN_KEY: ${{ secrets.GITHUB_TOKEN }}
5050
GITHUB_USER: ${{ github.actor }}
5151
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5252
- name: 'Warmup for game test server'

AGENTS.md

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,14 @@ When adding new features or fixing bugs:
6969
- **Always** add game tests when the feature interacts with Minecraft gameplay systems
7070
- Look at existing tests in the respective directories for examples of test patterns and conventions
7171

72+
### Testing advancements
73+
74+
When writing game tests for advancements, don't just call criterion triggers directly, but try to simulate actual game logic to invoke the criterion triggers indirectly.
75+
76+
### Test coverage
77+
78+
When adding new tests for the sake of increasing test coverage, you can measure coverage by running `./gradlew test runGameTestServer jacocoTestReport`, and checking the coverage output in `build/reports/jacoco/test/`.
79+
7280
## Building the Project
7381

7482
### Prerequisites
@@ -132,8 +140,6 @@ ln -s ../../scripts/pre-commit .git/hooks/pre-commit
132140
6. **Format code**: `./gradlew spotlessApply`
133141
7. **Commit**: Use clear, descriptive commit messages
134142

135-
## Project Dependencies
136-
137143
## Release Management
138144

139145
Version bumping and release management helper scripts are available in the [CyclopsMC/ReleaseHelpers](https://github.com/CyclopsMC/ReleaseHelpers) repository. These bash scripts assist with:
@@ -180,3 +186,18 @@ See `.github/workflows/ci.yml` for the full CI configuration.
180186
3. **Multi-loader compatibility**: Ensure changes work across all supported loaders
181187
4. **Build validation**: Never commit without running `build` (and `runGameTestServer` for MC 1.21+)
182188
5. **Code quality**: Follow existing patterns and conventions in the codebase
189+
190+
## Code changes across Minecraft updates
191+
192+
When I ask you to things such as "fix upmerge issues" or "update to the next Minecraft version",
193+
this means that I want you to help resolve compilation errors
194+
that were introduced due to upmerging code from an older minecraft version to a newer minecraft version.
195+
The old minecraft version can be found in the `.upmerge-src-branch` file of the parent directory,
196+
and the new minecraft version can be found in `gradle.properties`.
197+
Changes may also include fixing merge conflicts.
198+
199+
IMPORTANT: Some changes may be non-trivial,
200+
for which you can find detail background information for each seperate Minecraft update within these primers: https://github.com/neoforged/.github/tree/main/primers
201+
The blogs of https://neoforged.net/ and https://fabricmc.net/blog/ may also contain useful porting help.
202+
203+
After making all necessary changes, make sure the code fully compiles and the (game) tests pass.

CHANGELOG-1.20.1.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,20 @@
11
# Changelog for Minecraft 1.20.1
22
All notable changes to this project will be documented in this file.
33

4+
<a name="1.20.1-1.22.0"></a>
5+
## [1.20.1-1.22.0](/compare/1.20.1-1.21.3...1.20.1-1.22.0) - 2026-02-17 10:55:10
6+
7+
### Added
8+
* Add AND, OR, and NOT logical expression support to NBT path
9+
Expression such as `(@.a > 5 && @.a < 15) || @.a == 20` or
10+
`$.items[?(@.min < 10 && @.min > 5)]` can not be executed.
11+
Closes #210
12+
13+
### Changed
14+
* Modify value if needed when setting minValue in WidgetNumberField
15+
416
<a name="1.20.1-1.21.3"></a>
5-
## [1.20.1-1.21.3](/compare/1.20.1-1.21.2...1.20.1-1.21.3) - 2025-11-11 13:50:02
17+
## [1.20.1-1.21.3](/compare/1.20.1-1.21.2...1.20.1-1.21.3) - 2025-11-11 13:50:02 +0100
618

719
### Fixed
820
* Fix commands not being available after reload command

CHANGELOG-1.21.1.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,20 @@
11
# Changelog for Minecraft 1.21.1
22
All notable changes to this project will be documented in this file.
33

4+
<a name="1.21.1-1.29.0"></a>
5+
## [1.21.1-1.29.0](https://github.com/CyclopsMC/CyclopsCore/compare/1.21.1-1.28.0...1.21.1-1.29.0) - 2026-02-17 10:55:45
6+
7+
### Added
8+
* Add AND, OR, and NOT logical expression support to NBT path
9+
Expression such as `(@.a > 5 && @.a < 15) || @.a == 20` or
10+
`$.items[?(@.min < 10 && @.min > 5)]` can not be executed.
11+
Closes #210
12+
13+
### Changed
14+
* Modify value if needed when setting minValue in WidgetNumberField
15+
416
<a name="1.21.1-1.28.0"></a>
5-
## [1.21.1-1.28.0](https://github.com/CyclopsMC/CyclopsCore/compare/1.21.1-1.27.2...1.21.1-1.28.0) - 2025-12-22 13:54:29
17+
## [1.21.1-1.28.0](https://github.com/CyclopsMC/CyclopsCore/compare/1.21.1-1.27.2...1.21.1-1.28.0) - 2025-12-22 13:54:29 +0100
618

719
### Added
820
* Add helpers for registering to structure template pools
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
As always, don't forget to backup your world before updating!
2+
3+
Additions:
4+
* Add AND, OR, and NOT logical expression support to NBT path
5+
Expression such as `(@.a > 5 && @.a < 15) || @.a == 20` or
6+
`$.items[?(@.min < 10 && @.min > 5)]` can not be executed.
7+
Closes #210
8+
9+
Changes:
10+
* Modify value if needed when setting minValue in WidgetNumberField
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
As always, don't forget to backup your world before updating!
2+
3+
Additions:
4+
* Add AND, OR, and NOT logical expression support to NBT path
5+
Expression such as `(@.a > 5 && @.a < 15) || @.a == 20` or
6+
`$.items[?(@.min < 10 && @.min > 5)]` can not be executed.
7+
Closes #210
8+
9+
Changes:
10+
* Modify value if needed when setting minValue in WidgetNumberField

0 commit comments

Comments
 (0)