Fix crash when shift-clicking crafting output with empty result slot#199
Merged
rubensworks merged 1 commit intomaster-26from Apr 12, 2026
Merged
Fix crash when shift-clicking crafting output with empty result slot#199rubensworks merged 1 commit intomaster-26from
rubensworks merged 1 commit intomaster-26from
Conversation
Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedTerminals/sessions/ebc0a4b0-8094-4468-a1d8-4e51b8fd7d11 Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rubensworks
April 12, 2026 15:25
View session
Coverage Report for CI Build 24309972298Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.005%) to 8.634%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions8 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlayerInventoryWrapper.insert()throwsIllegalArgumentExceptionwhen passed an emptyItemResource(air). This was triggered during shift-click crafting output when the result slot was empty, since no guard existed before callinginsert.Change
Added an
isEmpty()check on the crafting resultItemStackbefore constructingItemResourceand callingPlayerInventoryWrapper.insert()— breaking the loop early if the slot is empty: