refactor: centralize plugin definitions and improve dynamic plugin discovery validation

Author: Armaldio

packages/core-node/src/handlers/plugins.ts

@@ -202,24 +202,16 @@ export const registerPluginsHandlers = (context: PipelabContext) => {
       const packagesDir = context.getPackagesPath();
       const rawInstalled = await findInstalledPlugins(packagesDir);
 
-      const DEFAULT_PLUGIN_IDS = [
-        "construct",
-        "filesystem",
-        "system",
-        "steam",
-        "itch",
-        "electron",
-        "discord",
-        "poki",
-        "nvpatch",
-        "tauri",
-        "minify",
-        "netlify",
-      ];
+      const { DEFAULT_PLUGIN_IDS, DEV_ONLY_PLUGIN_IDS } = await import("@pipelab/shared");
+      const defaultPluginIds = [...DEFAULT_PLUGIN_IDS];
+
+      if (isDev) {
+        defaultPluginIds.push(...DEV_ONLY_PLUGIN_IDS);
+      }
 
       const installed = rawInstalled
         .filter((item) => {
-          const isDefault = DEFAULT_PLUGIN_IDS.some((id) => item.name === `@pipelab/plugin-${id}`);
+          const isDefault = defaultPluginIds.some((id) => item.name === `@pipelab/plugin-${id}`);
           return !isDefault;
         })
         .map((item) => ({

packages/core-node/src/plugins-registry.ts

@@ -172,7 +172,11 @@ export async function findInstalledPlugins(
         try {
           const content = await readFile(join(dir, "package.json"), "utf8");
           const pkg = JSON.parse(content);
-          if (pkg.name && pkg.name !== "pnpm") {
+          if (
+            pkg.name &&
+            pkg.name !== "pnpm" &&
+            (pkg.pipelab || (pkg.keywords && pkg.keywords.includes("pipelab-plugin")))
+          ) {
             installed.push({
               name: pkg.name,
               version: pkg.version || "0.0.0",
@@ -222,20 +226,12 @@ export const builtInPlugins = async (options: { context: PipelabContext }): Prom
     const pluginsToLoad = new Map<string, string>(); // packageName -> version
 
     // Load default/native plugins by default
-    const defaultPlugins = [
-      "@pipelab/plugin-construct",
-      "@pipelab/plugin-filesystem",
-      "@pipelab/plugin-system",
-      "@pipelab/plugin-steam",
-      "@pipelab/plugin-itch",
-      "@pipelab/plugin-electron",
-      "@pipelab/plugin-discord",
-      "@pipelab/plugin-poki",
-      "@pipelab/plugin-nvpatch",
-      "@pipelab/plugin-tauri",
-      "@pipelab/plugin-minify",
-      "@pipelab/plugin-netlify",
-    ];
+    const { DEFAULT_PLUGIN_IDS, DEV_ONLY_PLUGIN_IDS } = await import("@pipelab/shared");
+    const defaultPlugins = [...DEFAULT_PLUGIN_IDS].map((id) => `@pipelab/plugin-${id}`);
+
+    if (isDev) {
+      defaultPlugins.push(...DEV_ONLY_PLUGIN_IDS.map((id) => `@pipelab/plugin-${id}`));
+    }
     for (const name of defaultPlugins) {
       pluginsToLoad.set(name, "latest");
     }

packages/shared/src/index.ts

@@ -50,6 +50,7 @@ export * from "./ipc.types";
 export * from "./logger";
 export * from "./model";
 export * from "./plugins";
+export * from "./plugins-list";
 export * from "./plugins/definitions"; // <-- RE-ADDED
 export * from "./quickjs";
 export * from "./save-location";

packages/shared/src/plugins-list.ts

@@ -0,0 +1,17 @@
+export const DEFAULT_PLUGIN_IDS = [
+  "construct",
+  "filesystem",
+  "system",
+  "steam",
+  "itch",
+  "electron",
+  "discord",
+  "poki",
+  "nvpatch",
+  "netlify",
+];
+
+export const DEV_ONLY_PLUGIN_IDS = [
+  "tauri",
+  "minify",
+];

plugins/plugin-construct/src/export-shared.ts

@@ -215,6 +215,8 @@ export const exportc3p = async <ACTION extends Action>(
     const pathsToCopy = [
       "https_editor.construct.net_0.indexeddb.blob",
       "https_editor.construct.net_0.indexeddb.leveldb",
+      "https_preview.construct.net_0.indexeddb.leveldb",
+      "https_account.construct.net_0.indexeddb.leveldb",
     ];
 
     for (const p of pathsToCopy) {