refactor: decouple app building from release deployment by introducing artifact upload steps

Author: Armaldio

.github/workflows/release.yml

@@ -53,11 +53,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   publish-apps:
-    name: Publish Apps (${{ matrix.os }} - ${{ matrix.arch }})
+    name: Build Apps (${{ matrix.os }} - ${{ matrix.arch }})
     needs: release
-    if: |
-      needs.release.outputs.published == 'true' ||
-      github.event.inputs.forcePublish == 'true'
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -84,30 +81,14 @@ jobs:
       - name: Install dependencies
         run: pnpm install
 
-      - name: Get Version
-        id: get_version
-        shell: bash
-        run: |
-          VERSION=$(node -p "require('./apps/desktop/package.json').version")
-          echo "VERSION=$VERSION" >> $GITHUB_ENV
-          echo "version=$VERSION" >> $GITHUB_OUTPUT
-          
-          IS_PRERELEASE="false"
-          if [[ $VERSION == *"-"* ]] || [[ ${{ github.event_name }} == "workflow_dispatch" && ${{ github.event.inputs.prerelease }} == "true" ]] || [[ ${{ github.ref_name }} == "feature/monorepo" ]]; then
-            IS_PRERELEASE="true"
-          fi
-          
-          echo "PRERELEASE=$IS_PRERELEASE" >> $GITHUB_ENV
-          echo "prerelease=$IS_PRERELEASE" >> $GITHUB_OUTPUT
-
       - name: Import Apple Code Signing Certificate
         uses: apple-actions/import-codesign-certs@v3
         if: matrix.os == 'macos-latest'
         with:
           p12-file-base64: ${{ secrets.CERTIFICATE_OSX_APPLICATION }}
           p12-password: ${{ secrets.CERTIFICATE_OSX_APPLICATION_PASSWORD }}
 
-      - name: Build, Package & Publish
+      - name: Build & Package
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
@@ -118,14 +99,59 @@ jobs:
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
           APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
-        run: pnpm turbo publish --filter=@pipelab/app -- --arch ${{ matrix.arch }}
+        run: pnpm turbo make --filter=@pipelab/app -- --arch ${{ matrix.arch }}
+
+      - name: Upload Desktop Artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: desktop-artifacts-${{ matrix.os }}-${{ matrix.arch }}
+          path: apps/desktop/out/make/**/*
 
-      - name: Upload Agent Binary to Release
+      - name: Upload CLI Artifacts
         if: matrix.arch == 'x64'
+        uses: actions/upload-artifact@v4
+        with:
+          name: cli-artifacts-${{ matrix.os }}-${{ matrix.arch }}
+          path: apps/cli/bin/*
+
+  deploy:
+    name: Deploy Release
+    needs: [release, publish-apps]
+    if: |
+      needs.release.outputs.published == 'true' ||
+      github.event.inputs.forcePublish == 'true'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Download all artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: artifacts
+
+      - name: Get Version
+        id: get_version
+        shell: bash
+        run: |
+          VERSION=$(node -p "require('./apps/desktop/package.json').version")
+          echo "VERSION=$VERSION" >> $GITHUB_ENV
+          echo "version=$VERSION" >> $GITHUB_OUTPUT
+          
+          IS_PRERELEASE="false"
+          if [[ $VERSION == *"-"* ]] || [[ ${{ github.event_name }} == "workflow_dispatch" && ${{ github.event.inputs.prerelease }} == "true" ]] || [[ ${{ github.ref_name }} == "feature/monorepo" ]]; then
+            IS_PRERELEASE="true"
+          fi
+          
+          echo "PRERELEASE=$IS_PRERELEASE" >> $GITHUB_ENV
+          echo "prerelease=$IS_PRERELEASE" >> $GITHUB_OUTPUT
+
+      - name: Create Release and Upload
         uses: softprops/action-gh-release@v2
         with:
-          tag_name: "v${{ env.VERSION }}"
-          prerelease: ${{ env.PRERELEASE == 'true' }}
-          files: apps/cli/bin/*
+          tag_name: "v${{ steps.get_version.outputs.version }}"
+          prerelease: ${{ steps.get_version.outputs.prerelease == 'true' }}
+          files: |
+            artifacts/desktop-artifacts-*/**/*
+            artifacts/cli-artifacts-*/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}