Skip to content

Fix enum error message to apply to global options#223

Merged
neuecc merged 1 commit into
Cysharp:masterfrom
dusrdev:master
Nov 26, 2025
Merged

Fix enum error message to apply to global options#223
neuecc merged 1 commit into
Cysharp:masterfrom
dusrdev:master

Conversation

@dusrdev

@dusrdev dusrdev commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

The updates in pull request #222 overlooked global options (sorry about that). This adjusts the ThrowArgumentParseFailed<T> method by removing the generic type parameter and having it accept the type directly.

ParseArgument<T> in global options would have forced us create the type through reflection in order to use the previous generic version, which is not something we want. This change avoids that.

@neuecc

neuecc commented Nov 26, 2025

Copy link
Copy Markdown
Member

ok, thanks!

@neuecc
neuecc merged commit 438f283 into Cysharp:master Nov 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants