feat: add MCP executable path support#360
Merged
Merged
Conversation
Contributor
|
Hey @samrusani, Nice work on this. I read it through against #347, and it does what was asked, with a clean setup! The executable path flows through the browser tools the right way, the global default, and per-call override both work. Two tiny things: if you ever want to polish, an empty path string is treated as unset, and a per-call path is ignored when a session id is reused, though neither blocks merging. Thanks for putting this together, this is quite helpful!! |
1 task
Owner
|
Thanks @samrusani for solving this one, and thanks @yetval for your review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds custom Chromium executable support to the MCP browser tools.
ScraplingMCPServernow accepts a globalexecutable_path, falls back toSCRAPLING_EXECUTABLE_PATH, and lets browser tool calls override it per request or session. The value is wired through toAsyncDynamicSessionandAsyncStealthySession, and thescrapling mcpcommand exposes--executable-pathso MCP users can configure it once.The MCP docs and API reference now show the server-wide configuration path.
Type of change:
Additional information
executable_path../.venv313/bin/python -m pytest tests/ai/test_ai_mcp.py::TestExecutablePath tests/cli/test_cli.py -q./.venv313/bin/python -m ruff check scrapling/./.venv313/bin/python -m ruff format --check scrapling/ --diff./.venv313/bin/python -m mypy scrapling/./.venv313/bin/python -m pyright --pythonpath ./.venv313/bin/python scrapling/git diff --checkChecklist: