Skip to content

Commit a22cbb2

Browse files
QuzarDCQuzarDC
authored andcommitted
Correct various doxygen warnings/issues.
In a few files group end markers were missing, in a few special characters needed escaping, and others had incorrect names in the doc vs the actual code.
1 parent dbdbc9b commit a22cbb2

8 files changed

Lines changed: 25 additions & 20 deletions

File tree

include/kos/cdefs.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
# warning Your GCC is too old. This will probably not work right.
3232
#endif
3333

34-
/** \defgroup system_attributes
34+
/** \defgroup system_attributes Function Attribute Defines
3535
\brief Definitions for builtin attributes and compiler directives
3636
\ingroup system
3737
@@ -173,7 +173,7 @@
173173

174174
/** @} */
175175

176-
/** \defgroup system_compat
176+
/** \defgroup system_compat Language Compatibility Defines
177177
\brief Definitions for language features
178178
\ingroup system
179179
@@ -206,7 +206,7 @@
206206

207207
/** @} */
208208

209-
/** \defgroup system_helpers
209+
/** \defgroup system_helpers Helper Macros
210210
\brief General useful language macros
211211
\ingroup system
212212
@@ -222,7 +222,7 @@
222222
by the compiler. This can only be used within a function.
223223
224224
Example:
225-
#include <stddef.h>
225+
\#include <stddef.h>
226226
...
227227
static char *foo_to_char(struct foo *foo)
228228
{
@@ -244,7 +244,7 @@
244244
by the compiler. This can be used in an expression: its value is "0".
245245
246246
Example:
247-
#define foo_to_char(foo) \
247+
\#define foo_to_char(foo) \
248248
((char *)(foo) \
249249
+ __build_assert_or_zero(offsetof(struct foo, string) == 0))
250250

kernel/arch/dreamcast/include/arch/irq.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
/* KallistiOS ##version##
22
3-
arch/dreamcast/include/irq.h
3+
arch/dreamcast/include/arch/irq.h
44
Copyright (C) 2000-2001 Megan Potter
55
Copyright (C) 2024 Paul Cercueil
66
Copyright (C) 2024 Falco Girgis
77
88
*/
99

10-
/** \file
10+
/** \file arch/irq.h
1111
\brief Interrupt and exception handling.
1212
\ingroup irqs
1313
@@ -57,7 +57,7 @@ __BEGIN_DECLS
5757
@{
5858
*/
5959

60-
/** \defgroup Context
60+
/** \defgroup irq_context Context
6161
\brief Thread execution state and accessors
6262
6363
This API includes the structure and accessors for a
@@ -437,7 +437,7 @@ typedef struct irq_cb {
437437
Passing a NULL value for hnd will remove the current handler, if any.
438438
439439
\param code The IRQ type to set the handler for
440-
(see \ref irq_exception_codes).
440+
(see #irq_t).
441441
\param hnd A pointer to a procedure to handle the exception.
442442
\param data A pointer that will be passed along to the callback.
443443
@@ -480,7 +480,7 @@ irq_cb_t irq_get_handler(irq_t code);
480480
\retval 0 On success (no error conditions defined).
481481
482482
*/
483-
int irq_set_global_handler(irq_handler handler, void *data);
483+
int irq_set_global_handler(irq_handler hnd, void *data);
484484

485485
/** Get the global exception handler.
486486

kernel/arch/dreamcast/include/arch/trap.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
66
*/
77

8-
/** \file
8+
/** \file arch/trap.h
99
\brief Interrupt and exception handling.
1010
\ingroup traps
1111
@@ -59,23 +59,23 @@ typedef uint8_t trapa_t;
5959

6060
/** The type of a TRAPA handler
6161
62-
\param trap The IRQ that caused the handler to be called.
62+
\param code The IRQ that caused the handler to be called.
6363
\param context The CPU's context.
6464
\param data Arbitrary userdata associated with the handler.
6565
*/
66-
typedef void (*trapa_handler)(trapa_t trap, irq_context_t *context, void *data);
66+
typedef void (*trapa_handler)(trapa_t code, irq_context_t *context, void *data);
6767

6868
/** Set or remove a handler for a trapa code.
6969
70-
\param trap The value passed to the trapa opcode.
70+
\param code The value passed to the trapa opcode.
7171
\param hnd A pointer to the procedure to handle the trap.
7272
\param data A pointer that will be passed along to the callback.
7373
7474
\retval 0 On success.
7575
7676
\sa trapa_get_handler()
7777
*/
78-
int trapa_set_handler(trapa_t trap, trapa_handler hnd, void *data);
78+
int trapa_set_handler(trapa_t code, trapa_handler hnd, void *data);
7979

8080
/** Get an existing TRAPA handler.
8181
@@ -87,7 +87,7 @@ int trapa_set_handler(trapa_t trap, trapa_handler hnd, void *data);
8787
8888
\sa trapa_set_handler()
8989
*/
90-
trapa_handler trapa_get_handler(trapa_t trap, void **data);
90+
trapa_handler trapa_get_handler(trapa_t code, void **data);
9191

9292
/** @} */
9393

kernel/arch/dreamcast/include/dc/maple/keyboard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ typedef enum __packed kbd_key {
247247
KBD_KEY_QUOTE = 0x34, /**< \brief " key */
248248
KBD_KEY_TILDE = 0x35, /**< \brief ~ key */
249249
KBD_KEY_COMMA = 0x36, /**< \brief , key */
250-
KBD_KEY_PERIOD = 0x37, /**< \brief . key */
250+
KBD_KEY_PERIOD = 0x37, /**< \brief \. key */
251251
KBD_KEY_SLASH = 0x38, /**< \brief Slash key */
252252
KBD_KEY_CAPSLOCK = 0x39, /**< \brief Caps Lock key */
253253
KBD_KEY_F1 = 0x3a, /**< \brief F1 key */

kernel/arch/dreamcast/include/dc/perf_monitor.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,5 +115,8 @@ void perf_monitor_exit(void);
115115
*/
116116
void perf_monitor_print(FILE *f);
117117

118+
/** @} */
119+
118120
__END_DECLS
121+
119122
#endif /* __KOS_PERF_MONITOR_H */

kernel/arch/dreamcast/include/dc/pvr/pvr_header.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,5 +351,8 @@ typedef __attribute__((aligned(32))) struct pvr_poly_hdr {
351351

352352
_Static_assert(sizeof(pvr_poly_hdr_t) == 32, "Invalid header size");
353353

354+
/** @} */
355+
354356
__END_DECLS
357+
355358
#endif /* __DC_PVR_PVR_HEADER_H */

kernel/arch/dreamcast/include/dc/sound/sound.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ void snd_adpcm_split(uint32_t *data, uint32_t *left, uint32_t *right, size_t siz
222222
This function returns actual the channel position
223223
that stores in SPU memory and updated by the SPU firmware.
224224
225-
\param chn The channel to retrieve position.
225+
\param ch The channel to retrieve position.
226226
227227
\return Last channel position in samples.
228228
*/
@@ -233,7 +233,7 @@ uint16_t snd_get_pos(unsigned int ch);
233233
This function returns actual the channel playback state
234234
that stores in AICA registers directly.
235235
236-
\param chn The channel to check.
236+
\param ch The channel to check.
237237
238238
\return True if the channel is playing.
239239
*/

kernel/arch/dreamcast/include/dc/sound/stream.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ void snd_stream_filter_remove(snd_stream_hnd_t hnd,
194194
This function has no effect. The stream is prefilled on start.
195195
This is deprecated and should be removed if used.
196196
197-
\param hnd Param.
198197
*/
199198
static const int __snd_stream_prefill __depr("snd_stream_prefill has no effect and should be removed") = 0;
200199
#define snd_stream_prefill(x) ((void)__snd_stream_prefill)

0 commit comments

Comments
 (0)