ref: remove unnecessary custom signals for preferences dialog

Author: paulmueller

CHANGELOG

@@ -4,6 +4,7 @@
  - enh: allow to disable update check on startup via settings
  - enh: apply button in upload settings only affects cache location
  - enh: move "apply" button in downloads settings next to "browse" button
+ - ref: remove unnecessary custom signals for preferences dialog
  - ref: decorate PyQtSlots
  - tests: restore previous users settings after testing
 0.17.3

dcoraid/gui/main.py

@@ -89,7 +89,7 @@ def __init__(self, *args, **kwargs):
         # Disable native menubar (e.g. on Mac)
         self.menubar.setNativeMenuBar(False)
         # File menu
-        self.actionPreferences.triggered.connect(self.dlg_pref.show_server)
+        self.actionPreferences.triggered.connect(self.dlg_pref.show)
         self.actionSetupWizard.triggered.connect(self.on_wizard)
         # Help menu
         self.actionSoftware.triggered.connect(self.on_action_software)

dcoraid/gui/preferences/dlg_preferences.py

@@ -18,9 +18,6 @@
 
 
 class PreferencesDialog(QtWidgets.QMainWindow):
-    show_server = QtCore.pyqtSignal()
-    show_user = QtCore.pyqtSignal()
-
     def __init__(self, *args, **kwargs):
         """Create a new window for preferences
         """
@@ -35,8 +32,6 @@ def __init__(self, *args, **kwargs):
         self.checkBox_check_updates.toggled.connect(
             self.on_general_check_for_updates)
         # server
-        self.show_server.connect(self.on_show_server)
-        self.show_user.connect(self.on_show_user)
         self.toolButton_server_update.clicked.connect(self.on_update_server)
         self.tabWidget.currentChanged.connect(self.on_tab_changed)
         self.toolButton_api_token_renew.clicked.connect(
@@ -243,7 +238,7 @@ def on_show_server(self):
         self.comboBox_server.setCurrentText(
             self.settings.value("auth/server", "dcor.mpl.mpg.de"))
         self.lineEdit_api_key.setText(self.settings.value("auth/api key", ""))
-        self.tabWidget.setCurrentIndex(0)  # server settings
+        self.tabWidget.setCurrentWidget(self.tab_server)
         self.lineEdit_api_key.setEchoMode(
             QtWidgets.QLineEdit.EchoMode.PasswordEchoOnEdit)
         self.show()