fix: do not attempt to updates non-existent eternal jobs on exit

Author: paulmueller

CHANGELOG

@@ -1,4 +1,5 @@
-0.19.1
+1.0.0
+ - fix: do not attempt to updates non-existent eternal jobs on exit
  - enh: allow users to specify circle IDs as well as names during upload
 0.19.0
  - feat: share dialog for collections and datasets

dcoraid/upload/queue.py

@@ -3,7 +3,6 @@
 import time
 import threading
 import traceback
-import traceback as tb
 import warnings
 
 from ..api import APINotFoundError
@@ -158,7 +157,7 @@ def __init__(self, api, path_persistent_job_list=None, cache_dir=None):
                                   f"file {pp}.",
                                   DCORAidQueueWarning)
                 except LocalTaskResourcesNotFoundError as e:
-                    self.logger.error(tb.format_exc())
+                    self.logger.error(traceback.format_exc())
                     resstr = ", ".join([str(pp) for pp in e.missing_resources])
                     warnings.warn(
                         "The following resources are missing for dataset "
@@ -179,7 +178,8 @@ def __del__(self):
         # Attempt to update the eternal jobs (important for ETags)
         for job in self.jobs:
             try:
-                self.jobs_eternal.update_job(job)
+                if self.jobs_eternal.job_exists(job.dataset_id):
+                    self.jobs_eternal.update_job(job)
             except BaseException:
                 self.logger.error(traceback.format_exc())
         self.daemon_upload.shutdown_flag.set()