enh: speed-up tests by skipping database update on startup

Author: paulmueller

dcoraid/gui/main.py

@@ -142,10 +142,9 @@ def __init__(self, *args, **kwargs):
                     QtCore.QStandardPaths.StandardLocation.CacheLocation)
                 )
             self._last_asked_about_update = self.database.local_timestamp
-            self.check_update_database(
-                force=bool(int(self.settings.value(
-                    "force update database on startup", "0")))
-            )
+            if not bool(int(self.settings.value(
+                    "skip database update on startup", "0"))):
+                self.check_update_database()
         except BaseException:
             self.logger.error(traceback.format_exc())
         else:
@@ -207,7 +206,9 @@ def check_update_database(self, reset=False, force=False):
                 "Performing database update, please wait..." + " "*20,
                 "Abort",
                 0,
-                0)
+                0,
+                self
+            )
             prog.canceled.connect(abort_event.set)
             prog.setMinimumDuration(0)
             prog.setModal(True)
@@ -216,10 +217,12 @@ def check_update_database(self, reset=False, force=False):
             def prog_update_callback(data):
                 cdict = data["circle_current"]
                 new_ds = data["datasets_new"]
-                circle_name = cdict.get("title", cdict.get("name", "data"))
-                if len(circle_name) > 50:
-                    circle_name = circle_name[:50] + "..."
-                prog.setLabelText(f"Fetching '{circle_name}'\n"
+                title = cdict.get("title")
+                if not title:
+                    title = cdict.get("name")
+                if len(title) > 50:
+                    title = title[:50] + "..."
+                prog.setLabelText(f"Fetching '{title}'\n"
                                   f"Imported {new_ds} datasets so far.")
 
             thr = threading.Thread(target=self.database.update,

tests/conftest.py

@@ -66,7 +66,7 @@ def pytest_configure(config):
         settings.setValue(key, value)
     # removing timers breaks the user workflow, so it is not in change_settings
     settings.setValue("debug/without timers", "1")
-    settings.setValue("force update database on startup", "1")
+    settings.setValue("skip database update on startup", "1")
     settings.sync()
     # cleanup
     cleanup_dcoraid_tasks()
@@ -88,7 +88,7 @@ def pytest_unconfigure(config):
         settings.setValue(key, USER_SETTINGS[key])
     # always remove this setting, because it breaks the user workflow
     settings.remove("debug/without timers")
-    settings.remove("force update database on startup")
+    settings.remove("skip database update on startup")
     settings.sync()
     # cleanup
     cleanup_dcoraid_tasks()

tests/test_gui.py

@@ -68,7 +68,7 @@ def test_gui_anonymous(qtbot):
         "[General]",
         "user%20scenario = anonymous",
         "check for updates = 0",
-        "force update database on startup = 1",
+        "skip database update on startup = 1",
         "[auth]",
         "api%20key =",
         "server = dcor.mpl.mpg.de",