fix: cleanup error message dialog

Author: paulmueller

CHANGELOG

@@ -1,6 +1,8 @@
 0.17.3
- - fix: Drag'n'Drop to DCscope broken since 0.17.0 (#88)
+ - fix: drag'n'drop to DCscope broken since 0.17.0 (#88)
  - fix: show long resource names with elide-middle and tool tip (#89)
+ - fix: error message dialog limited to traceback length of three
+ - fix: copy error text to clipboard did not work in error message dialog
  - enh: allow specifying collections in upload task files and via the API
  - docs: increase warning threshold for max number of resources to 1000
    (CKAN 2.11.3 handles datasets with many resources much better)

dcoraid/gui/main.py

@@ -265,12 +265,13 @@ def excepthook(etype, value, trace):
         call last)``.
     """
     vinfo = f"Unhandled exception in DCOR-Aid version {__version__}:\n"
-    tmp = tb.format_exception(etype, value, trace)
-    exception = "".join([vinfo] + tmp)
+    exc_long = "".join([vinfo] + tb.format_exception(etype, value, trace))
+    exc_short = "".join([vinfo] + tb.format_exception(
+        etype, value, trace, limit=3))
 
     # log the exception
     logger = logging.getLogger(__name__)
-    logger.error(exception)
+    logger.error(exc_long)
 
     # Test connectivity
     if etype is APIOutdatedError:
@@ -283,16 +284,20 @@ def excepthook(etype, value, trace):
 
     errorbox = QtWidgets.QMessageBox()
     errorbox.setIcon(QtWidgets.QMessageBox.Icon.Critical)
+    copy_button = QtWidgets.QPushButton('Copy message to clipboard and close')
+    copy_button.clicked.connect(lambda: copy_text_to_clipboard(exc_long))
     errorbox.addButton(QtWidgets.QPushButton('Close'),
                        QtWidgets.QMessageBox.ButtonRole.YesRole)
-    errorbox.addButton(QtWidgets.QPushButton(
-        'Copy text && Close'), QtWidgets.QMessageBox.ButtonRole.NoRole)
-    errorbox.setText(exception)
-    ret = errorbox.exec()
-    if ret == 1:
-        cb = QtWidgets.QApplication.clipboard()
-        cb.clear(mode=cb.Clipboard)
-        cb.setText(exception)
+    errorbox.addButton(copy_button, QtWidgets.QMessageBox.ButtonRole.NoRole)
+    errorbox.setDetailedText(exc_long)
+    errorbox.setText(exc_short)
+    errorbox.exec()
+
+
+def copy_text_to_clipboard(text):
+    cb = QtWidgets.QApplication.clipboard()
+    cb.clear()
+    cb.setText(text)
 
 
 # Make Ctr+C close the app