enh: move "apply" button in downloads settings next to "browse" button

Author: paulmueller

CHANGELOG

@@ -3,6 +3,7 @@
  - fix: `get_datasets_user_shared` failed when many circles/collections exist
  - enh: allow to disable update check on startup via settings
  - enh: apply button in upload settings only affects cache location
+ - enh: move "apply" button in downloads settings next to "browse" button
  - ref: decorate PyQtSlots
  - tests: restore previous users settings after testing
 0.17.3

dcoraid/gui/preferences/dlg_preferences.py

@@ -54,8 +54,8 @@ def __init__(self, *args, **kwargs):
         # downloads
         self.toolButton_downloads_browse.clicked.connect(
             self.on_downloads_browse)
-        self.toolButton_downloads_apply.clicked.connect(
-            self.on_downloads_apply)
+        self.toolButton_downloads_path_apply.clicked.connect(
+            self.on_downloads_path_apply)
         # account
         self.toolButton_user_update.clicked.connect(self.on_update_user)
 
@@ -193,10 +193,6 @@ def on_api_token_revoke(self):
             self.logger.info("Exiting, because user revoked API token.")
             QtWidgets.QApplication.quit()
 
-    def on_downloads_apply(self):
-        path = self.lineEdit_downloads_path.text()
-        self.settings.setValue("downloads/default path", path)
-
     def on_downloads_browse(self):
         default = self.settings.value("downloads/default path", ".")
         path = QtWidgets.QFileDialog.getExistingDirectory(
@@ -207,6 +203,10 @@ def on_downloads_browse(self):
         if path and pathlib.Path(path).exists():
             self.lineEdit_downloads_path.setText(path)
 
+    def on_downloads_path_apply(self):
+        path = self.lineEdit_downloads_path.text()
+        self.settings.setValue("downloads/default path", path)
+
     def on_uploads_browse(self):
         default = self.settings.value("uploads/cache path", ".")
         path = QtWidgets.QFileDialog.getExistingDirectory(

dcoraid/gui/preferences/dlg_preferences.ui

@@ -304,25 +304,8 @@ dataset identifier assigned to it by CKAN/DCOR.</string>
             </property>
            </widget>
           </item>
-         </layout>
-        </item>
-        <item>
-         <layout class="QHBoxLayout" name="horizontalLayout_6">
-          <item>
-           <spacer name="horizontalSpacer_4">
-            <property name="orientation">
-             <enum>Qt::Orientation::Horizontal</enum>
-            </property>
-            <property name="sizeHint" stdset="0">
-             <size>
-              <width>40</width>
-              <height>20</height>
-             </size>
-            </property>
-           </spacer>
-          </item>
           <item>
-           <widget class="QToolButton" name="toolButton_downloads_apply">
+           <widget class="QToolButton" name="toolButton_downloads_path_apply">
             <property name="text">
              <string>Apply</string>
             </property>