@@ -233,7 +233,7 @@ def _get_intra_dataset_upstream_basins(res_dict, ds) -> list[dict]:
233233
234234 # get the actual features available for this basin
235235 ds_s3_res = s3cc .get_s3_dc_handle (u_rid , "resource" )
236- basin_feats = _get_remote_features_from_basins (ds_s3_res )
236+ basin_feats = _get_all_features_with_remote (ds_s3_res )
237237 for ii in range (10 ):
238238 # Workaround. I experienced AttributeErrors during
239239 # testing ('S3File' object has no attribute 'seek'),
@@ -257,7 +257,7 @@ def _get_intra_dataset_upstream_basins(res_dict, ds) -> list[dict]:
257257 f"intra-dataset basin; traceback follows." )
258258 logger .warning (traceback .format_exc ())
259259 else :
260- con_f = _get_remote_features_from_basins (ds_s3_con )
260+ con_f = _get_all_features_with_remote (ds_s3_con )
261261 basin_feats = sorted (set (basin_feats + con_f ))
262262 break
263263
@@ -285,9 +285,9 @@ def _get_intra_dataset_upstream_basins(res_dict, ds) -> list[dict]:
285285 return basin_dicts
286286
287287
288- def _get_remote_features_from_basins (ds ):
289- """Return list of remote features from basins of this dataset """
290- features = []
288+ def _get_all_features_with_remote (ds ):
289+ """Return features, including remote features from basins"""
290+ features = ds . features
291291 for bn in ds .basins_get_dicts ():
292292 if bn ["type" ] == "remote" :
293293 features += bn ["features" ]
0 commit comments