refactor: remove unused parameter from applyGeminiToolConfigDefaults function

Noxiven · Noxiven · commit 5bafe40df3a2 · 2026-07-08T14:05:50.000+08:00
diff --git a/backend/internal/infra/llm/gemini.go b/backend/internal/infra/llm/gemini.go
@@ -153,7 +153,7 @@ func buildGeminiRequestBody(input GenerateInput) (map[string]interface{}, error)
 		webSearchTools = append(webSearchTools, map[string]interface{}{"google_search": map[string]interface{}{}})
 	}
 	appendToolDeclarations(payload, providerTools, webSearchTools, buildGeminiTools(toolDefinitions))
-	applyGeminiToolConfigDefaults(payload, len(providerTools)+len(webSearchTools) > 0, len(toolDefinitions) > 0)
+	applyGeminiToolConfigDefaults(payload, len(providerTools)+len(webSearchTools) > 0)
 
 	if len(systemTextParts) > 0 {
 		payload["systemInstruction"] = map[string]interface{}{
@@ -167,8 +167,8 @@ func buildGeminiRequestBody(input GenerateInput) (map[string]interface{}, error)
 	return payload, nil
 }
 
-func applyGeminiToolConfigDefaults(payload map[string]interface{}, hasServerSideTools bool, hasFunctionDeclarations bool) {
-	if !hasServerSideTools || !hasFunctionDeclarations {
+func applyGeminiToolConfigDefaults(payload map[string]interface{}, hasServerSideTools bool) {
+	if !hasServerSideTools {
 		return
 	}
 	toolConfig := asMap(payload["toolConfig"])

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ func buildGeminiRequestBody(input GenerateInput) (map[string]interface{}, error)`
`153`	`153`	`webSearchTools = append(webSearchTools, map[string]interface{}{"google_search": map[string]interface{}{}})`
`154`	`154`	`}`
`155`	`155`	`appendToolDeclarations(payload, providerTools, webSearchTools, buildGeminiTools(toolDefinitions))`
`156`		`- applyGeminiToolConfigDefaults(payload, len(providerTools)+len(webSearchTools) > 0, len(toolDefinitions) > 0)`
	`156`	`+ applyGeminiToolConfigDefaults(payload, len(providerTools)+len(webSearchTools) > 0)`
`157`	`157`
`158`	`158`	`if len(systemTextParts) > 0 {`
`159`	`159`	`payload["systemInstruction"] = map[string]interface{}{`
`@@ -167,8 +167,8 @@ func buildGeminiRequestBody(input GenerateInput) (map[string]interface{}, error)`
`167`	`167`	`return payload, nil`
`168`	`168`	`}`
`169`	`169`
`170`		`-func applyGeminiToolConfigDefaults(payload map[string]interface{}, hasServerSideTools bool, hasFunctionDeclarations bool) {`
`171`		`- if !hasServerSideTools \|\| !hasFunctionDeclarations {`
	`170`	`+func applyGeminiToolConfigDefaults(payload map[string]interface{}, hasServerSideTools bool) {`
	`171`	`+ if !hasServerSideTools {`
`172`	`172`	`return`
`173`	`173`	`}`
`174`	`174`	`toolConfig := asMap(payload["toolConfig"])`