feat: enhance JsonCodeEditor with autoFocus support#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the chat model parameter configuration dialog so the JSON editor can reliably receive focus and accept input.
JsonCodeEditornow supportsautoFocus, avoids emitting change events during controlled value synchronization, preserves focus when external values are applied, and disables MonacoeditContextto avoid browser input compatibility issues.The model configuration dialog now keeps the JSON editor mounted across mobile tab switches and enables autofocus when opening the dialog, preventing the editor from losing its input state or focus when switching between JSON and visual configuration.
Change type
Affected areas
Verification
Screenshots, API examples, or logs
N/A
Configuration, migration, and compatibility notes
No backend API, database schema, deployment, or configuration changes.
Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.