feat: add emailVerifiedField to identity provider model and update related logic#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve OAuth account linking and authentication UX. OAuth login can now safely link an existing account by normalized email when the provider reports a verified email, while manual account binding remains available for already authenticated users. The login page no longer exposes a separate third-party “register” flow, and the OAuth callback page avoids false “session expired” flashes caused by duplicate React effect execution.
Also improves frontend error presentation so settings and admin operation failures show concrete backend validation messages instead of generic toast text.
Change type
Affected areas
Verification
cd backend && go test ./...cd frontend && pnpm lintgit diff --checkScreenshots, API examples, or logs
N/A
Configuration, migration, and compatibility notes
Adds
email_verified_fieldto identity provider configuration, defaulting toemail_verified. Existing providers continue to work with the default value, and admins can override the field mapping for providers such as Discord.No deployment configuration changes are required.
OAuth auto-linking only occurs when the provider email is verified. Manual binding is still allowed from an authenticated account and continues to protect against binding an identity already owned by another account.
Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.