feat: support optional file cleanup when deleting conversations#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional file cleanup flow when deleting conversations or deleting projects with conversations. Users can choose to also delete files attached to deleted conversations, while files still referenced by other active conversations are kept.
The backend now re-checks file references before deleting file objects, returns the deleted file count and latest storage quota, and updates Swagger. The frontend adds delete-file checkboxes in conversation/project delete dialogs and refreshes the Files page through a shared file-library invalidation event.
Change type
Affected areas
Verification
cd backend && go test ./...cd backend && make swaggercd frontend && pnpm lintcd frontend && pnpm buildScreenshots, API examples, or logs
Not included. UI changes are limited to delete confirmation options.
Configuration, migration, and compatibility notes
Configuration changes: None.
API changes:
DELETE /api/v1/conversations/:idsupportsdelete_files=true.DELETE /api/v1/conversation-projects/:idsupportsdelete_files=truewhen deleting project conversations.deletedFileCountand may include latest storagequota.Database migrations: None.
Deployment changes: None.
Backward compatibility: Existing delete behavior is unchanged unless
delete_files=trueis provided. Files referenced by other active conversations are not deleted.Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.