Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix sidebar conversation infinite scrolling failing after the initial 50 conversations.
The load-more sentinel could be rendered after its effect had already run because the real list content is mounted asynchronously by
LoadingReveal. Since changes toref.currentdo not trigger effects, the observer was never attached until the recent section was collapsed and expanded.Update
useLoadMoreSentinelto return a callback ref so observer setup runs whenever the sentinel DOM element is mounted. Migrate existing consumers to the same lifecycle-safe API without changing pagination behavior.Change type
Affected areas
Verification
cd frontend && pnpm lintgit diff --checkScreenshots, API examples, or logs
No visual changes.
Expected regression flow:
Configuration, migration, and compatibility notes
No configuration, API, database, deployment, or migration changes.
The shared load-more hook now returns a callback ref instead of accepting a target ref object. All existing internal consumers were migrated.
Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.