fix: settle usage beyond available balance#477
Merged
Conversation
hrx114514x
marked this pull request as ready for review
July 14, 2026 03:19
chenyme
self-requested a review
July 14, 2026 03:22
37 tasks
chenyme
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #471.
Root cause
The final settlement transactions returned
ErrInsufficientBalancewhen the actual charge exceeded the remaining balance after reservation. That rolled back both the usage ledger and the balance update. The HTTP layer then treated settlement as failed and released the reservation, restoring the account to a usable balance even though the upstream request had already consumed tokens.Changes
No API, schema, configuration, or frontend changes are included.
Concurrency and behavior
The existing account row lock remains the serialization point for balance updates and period-credit recalculation. Requests that are already in flight can still complete and are charged in commit order, potentially increasing the negative balance; once a settlement records debt, subsequent paid-model access is rejected by the existing balance check.
This pull request intentionally does not add per-model maximum-cost estimation or change the prepaid amount configuration.
Testing
cd backend && go test ./...cd backend && go test -race ./internal/infra/persistence/postgres/billing ./internal/application/billinggit diff --check