feat: add buttonRef prop and focus management#482
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the model picker showing two visually highlighted models when reopening it after selecting a model that is not first in its vendor list.
The picker previously used the same background for the selected model and the automatically focused first item. It now places the initial desktop focus on the currently selected model, keeping selection and focus aligned while preserving keyboard accessibility.
Change type
Affected areas
Verification
cd frontend && pnpm lintcd frontend && pnpm exec tsc --noEmitgit diff --checkScreenshots, API examples, or logs
The reproduction screenshot is included in the linked issue. No API or backend behavior changed.
Configuration, migration, and compatibility notes
No configuration, migration, deployment, API contract, or model routing changes are required. Mobile model picker behavior remains unchanged.
Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.