Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move frontend branding from build-time
NEXT_PUBLIC_*variables to runtimeconfig.yamlconfiguration.BrandingProvider./manifest.webmanifestcompatibility for existing PWA installations.Change type
Affected areas
Verification
cd backend && go test ./...cd frontend && pnpm lintcd frontend && pnpm exec tsc --noEmitgit diff --checkcd frontend && pnpm buildScreenshots, API examples, or logs
Verified that runtime branding remains the single title, favicon, and manifest source after client-side navigation.
New public endpoints:
Configuration, migration, and compatibility notes
Branding configuration moves from frontend
NEXT_PUBLIC_*variables to the rootconfig.yaml:config.yaml.NEXT_PUBLIC_API_BASE_URLto locate the backend.server.cors_allow_originandserver.public_web_base_url.Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.