Fix QR code alignment pattern placement for 2FA setup#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the custom QR code generator so it correctly places alignment patterns that overlap timing rows or columns.
Why
During 2FA setup, valid
otpauth://data from the backend could produce an unreadable QR code on the frontend. The QR generator skipped any alignment pattern whose center was already marked as reserved. For Version 7 QR codes, this incorrectly skipped valid alignment patterns at(22, 6)and(6, 22)because they overlap the timing row/column.What Changed
Verification
shared/lib/qr-code.ts.