feat: add delete files by default setting for chat conversations#84
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a user-level chat preference for deleting conversation files by default.
Users can now enable a setting in chat preferences so delete conversation confirmations default to also deleting files. The confirmation checkbox remains visible and can still be changed per deletion. Existing backend deletion behavior is preserved: files referenced by other conversations are kept.
A shared
useChatPreferenceshook was added so frontend chat preferences are read consistently and cached across conversation UI entry points.Change type
Affected areas
Verification
cd backend && go test ./internal/application/usersettingscd frontend && pnpm lintgit diff --checkScreenshots, API examples, or logs
N/A
Configuration, migration, and compatibility notes
Adds user setting key
chat.delete_conversation_files_by_default, defaulting tofalse.No database migration is required because this uses the existing user settings table. Existing users keep the current behavior unless they enable the new setting.
Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.