Skip to content

Move onRequest from prehandler to get and post handlers #849

Move onRequest from prehandler to get and post handlers

Move onRequest from prehandler to get and post handlers #849

Triggered via pull request October 6, 2025 11:42
Status Failure
Total duration 2m 52s
Artifacts 1

check-pull-request.yml

on: pull_request
Matrix: tasks
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 1 warning
TypeScript compiler
Process completed with exit code 2.
Unit tests
Process completed with exit code 1.
makePostHandler › throws when model is missing: src/server/plugins/engine/routes/questions.test.ts#L365
expect(received).toEqual(expected) // deep equality Expected: [Error: No model found for /some-path] Received: [TypeError: fn is not a function] at Object.toEqual (src/server/plugins/engine/routes/questions.test.ts:365:19)
makePostHandler › does not call the callback when events.onSave.type is http and the page controller was unsuccessful: src/server/plugins/engine/routes/questions.test.ts#L314
TypeError: fn is not a function at fn (src/server/plugins/engine/routes/questions.test.ts:314:25) at postHandler (src/server/plugins/engine/routes/questions.ts:129:33) at Object.<anonymous> (src/server/plugins/engine/routes/questions.test.ts:317:28)
makePostHandler › does not call the callback when the events.onSave.type is not http: src/server/plugins/engine/routes/questions.test.ts#L273
TypeError: fn is not a function at fn (src/server/plugins/engine/routes/questions.test.ts:273:25) at postHandler (src/server/plugins/engine/routes/questions.ts:129:33) at Object.<anonymous> (src/server/plugins/engine/routes/questions.test.ts:276:28)
makePostHandler › calls the callback when events.onSave.type is http and the page controller was successful: src/server/plugins/engine/routes/questions.test.ts#L234
TypeError: fn is not a function at fn (src/server/plugins/engine/routes/questions.test.ts:234:25) at postHandler (src/server/plugins/engine/routes/questions.ts:129:33) at Object.<anonymous> (src/server/plugins/engine/routes/questions.test.ts:237:45)
makeGetHandler › throws when model is missing: src/server/plugins/engine/routes/questions.test.ts#L180
expect(received).toEqual(expected) // deep equality Expected: [Error: No model found for /some-path] Received: [TypeError: fn is not a function] at Object.toEqual (src/server/plugins/engine/routes/questions.test.ts:180:19)
makeGetHandler › does not call the callback when the events.onLoad.type is not http: src/server/plugins/engine/routes/questions.test.ts#L130
TypeError: fn is not a function at fn (src/server/plugins/engine/routes/questions.test.ts:130:25) at getHandler (src/server/plugins/engine/routes/questions.ts:88:33) at Object.<anonymous> (src/server/plugins/engine/routes/questions.test.ts:133:27)
makeGetHandler › calls the callback when events.onLoad.type is http: src/server/plugins/engine/routes/questions.test.ts#L88
TypeError: fn is not a function at fn (src/server/plugins/engine/routes/questions.test.ts:88:25) at getHandler (src/server/plugins/engine/routes/questions.ts:88:33) at Object.<anonymous> (src/server/plugins/engine/routes/questions.test.ts:91:27)
Vulnerability warning
This version of the SonarQube Scanner GitHub Action is no longer supported and contains a security vulnerability. Please update your workflow to use sonarsource/sonarqube-scan-action@v6 for the latest security patches and features. For more information visit https://community.sonarsource.com/gha-v6-update

Artifacts

Produced during runtime
Name Size Digest
Unit tests coverage Expired
577 KB
sha256:f19524b2de06a170b2595a67731d9476a9f8ebf626e14065c1413c9942c70f85