-
Notifications
You must be signed in to change notification settings - Fork 3
Expand file tree
/
Copy pathform-context.test.ts
More file actions
373 lines (322 loc) · 11.5 KB
/
form-context.test.ts
File metadata and controls
373 lines (322 loc) · 11.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
import { type Request } from '@hapi/hapi'
import {
getFirstJourneyPage,
getFormContext,
getFormModel,
resolveFormModel,
type FormModelOptions
} from '~/src/server/plugins/engine/beta/form-context.js'
import { PageController } from '~/src/server/plugins/engine/pageControllers/PageController.js'
import { type PageControllerClass } from '~/src/server/plugins/engine/pageControllers/helpers/pages.js'
import { type FormContext } from '~/src/server/plugins/engine/types.js'
import { FormStatus } from '~/src/server/routes/types.js'
import { type FormsService, type Services } from '~/src/server/types.js'
const mockGetCacheService = jest.fn()
const mockCacheService = { getState: jest.fn() }
const mockCheckEmailAddressForLiveFormSubmission = jest.fn()
jest.mock('../models/index.ts', () => ({
__esModule: true,
FormModel: jest.fn()
}))
jest.mock('~/src/server/plugins/engine/services/index.js', () => ({
__esModule: true,
formsService: {
getFormMetadata: jest.fn(),
getFormDefinition: jest.fn()
},
formSubmissionService: {},
outputService: {}
}))
jest.mock('../pageControllers/index.ts', () => {
class MockTerminalPageController {
path = ''
}
return {
__esModule: true,
TerminalPageController: MockTerminalPageController
}
})
jest.mock('../helpers.ts', () => ({
...jest.requireActual('../helpers.ts'),
getCacheService: (...args: unknown[]) => mockGetCacheService(...args),
checkEmailAddressForLiveFormSubmission: (...args: unknown[]) =>
mockCheckEmailAddressForLiveFormSubmission(...args)
}))
const mockServices = jest.requireMock(
'~/src/server/plugins/engine/services/index.js'
)
const mockFormsService = mockServices.formsService
const { FormModel } = jest.requireMock('../models/index.ts')
const { TerminalPageController: MockTerminalPageController } = jest.requireMock(
'../pageControllers/index.ts'
)
describe('getFormContext helper', () => {
const request = {
yar: { set: jest.fn() } as unknown as Request['yar'],
server: {
app: {},
realm: { modifiers: { route: { prefix: '' } } }
} as unknown as Request['server']
} satisfies Pick<Request, 'yar' | 'server'>
const slug = 'tb-origin'
const cachedState = { answered: true }
const returnedContext = { errors: [] }
const metadata = {
id: 'metadata-123',
live: { updatedAt: new Date('2024-10-15T10:00:00Z') },
draft: { updatedAt: new Date('2024-10-10T10:00:00Z') },
versions: [{ versionNumber: 9 }],
notificationEmail: 'test@example.com'
}
const definition = { pages: [] }
let formModel: { getFormContext: jest.Mock }
beforeEach(() => {
jest.clearAllMocks()
formModel = { getFormContext: jest.fn().mockResolvedValue(returnedContext) }
FormModel.mockImplementation(
(_definition: unknown, modelOptions: FormModelOptions) =>
Object.assign(formModel, { basePath: modelOptions.basePath })
)
mockFormsService.getFormMetadata.mockResolvedValue(metadata)
mockFormsService.getFormDefinition.mockResolvedValue(definition)
mockGetCacheService.mockReturnValue(mockCacheService)
mockCacheService.getState.mockResolvedValue(cachedState)
})
test('passes preview state into the summary request and uses cached reference numbers', async () => {
const errors = [
{ href: '#field', name: 'field', path: ['field'], text: 'is required' }
]
mockCacheService.getState.mockResolvedValue({
...cachedState,
$$__referenceNumber: 'CACHED-REF'
})
const context = await getFormContext(request, slug, 'preview', {
errors
})
const summaryRequest = mockCacheService.getState.mock.calls[0][0]
expect(summaryRequest.params).toEqual({
path: 'summary',
slug,
state: 'live'
})
expect(summaryRequest.path).toBe('/preview/live/tb-origin/summary')
expect(summaryRequest.url.toString()).toBe(
'https://form-context.local/preview/live/tb-origin/summary'
)
expect(formModel.getFormContext).toHaveBeenCalledWith(
summaryRequest,
expect.objectContaining({ $$__referenceNumber: 'CACHED-REF' }),
errors
)
expect(context).toBe(returnedContext)
})
})
describe('getFormModel helper', () => {
const slug = 'tb-origin'
const state = FormStatus.Draft
class CustomController extends PageController {}
const controllers = { CustomController }
const metadata = {
id: 'form-meta-123'
}
const definition = {
pages: [{ path: '/start' }],
metadata: {
$$__formVersion: {
versionNumber: 17,
createdAt: new Date('2024-10-15T10:00:00Z')
}
}
}
let formsService: FormsService
let services: Services
let formModelInstance: { id: string }
beforeEach(() => {
jest.clearAllMocks()
formModelInstance = { id: 'form-model-instance' }
FormModel.mockImplementation(() => formModelInstance)
services = {
formsService: {
getFormMetadata: jest.fn().mockResolvedValue(metadata),
getFormMetadataById: jest.fn(),
getFormDefinition: jest.fn().mockResolvedValue(definition),
getFormSecret: jest.fn()
},
formSubmissionService: {
persistFiles: jest.fn(),
submit: jest.fn()
},
outputService: {
submit: jest.fn()
}
}
formsService = services.formsService
})
test('constructs a FormModel using fetched metadata and definition', async () => {
const model = await getFormModel(slug, state, { services, controllers })
expect(formsService.getFormMetadata).toHaveBeenCalledWith(slug)
expect(formsService.getFormDefinition).toHaveBeenCalledWith(
metadata.id,
state
)
expect(FormModel).toHaveBeenCalledWith(
definition,
{
basePath: slug,
ordnanceSurveyApiKey: undefined,
formId: metadata.id
},
services,
controllers
)
expect(model).toBe(formModelInstance)
})
test('maps preview state requests to the live form definition', async () => {
await getFormModel(slug, 'preview', { services, controllers })
expect(formsService.getFormDefinition).toHaveBeenCalledWith(
metadata.id,
'live'
)
})
test('throws when no form definition is available', async () => {
jest.mocked(formsService.getFormDefinition).mockResolvedValue(undefined)
await expect(
getFormModel(slug, state, { services, controllers })
).rejects.toThrow(
`No definition found for form metadata ${metadata.id} (${slug}) ${state}`
)
expect(FormModel).not.toHaveBeenCalled()
})
})
describe('resolveFormModel helper', () => {
const slug = 'tb-origin'
const definition = {
pages: [],
metadata: {
$$__formVersion: {
versionNumber: 9,
createdAt: new Date('2024-10-15T10:00:00Z')
}
}
}
const metadata = {
id: 'metadata-123',
live: { updatedAt: new Date('2024-10-15T10:00:00Z') },
notificationEmail: 'enrique.chase@defra.gov.uk'
}
let server: Request['server']
let formModelInstance: { id: string }
beforeEach(() => {
jest.clearAllMocks()
server = {
app: {},
realm: { modifiers: { route: { prefix: '/forms/' } } }
} as unknown as Request['server']
formModelInstance = { id: 'form-model-instance' }
FormModel.mockImplementation(() => formModelInstance)
mockFormsService.getFormMetadata.mockResolvedValue(metadata)
mockFormsService.getFormDefinition.mockResolvedValue(definition)
})
test('reuses cached models when metadata timestamps match', async () => {
const model = await resolveFormModel(server, slug, FormStatus.Live)
const cached = await resolveFormModel(server, slug, FormStatus.Live)
expect(model).toBe(formModelInstance)
expect(cached).toBe(model)
expect(server.app.models).toBeInstanceOf(Map)
expect(mockFormsService.getFormDefinition).toHaveBeenCalledTimes(1)
expect(FormModel).toHaveBeenCalledTimes(1)
})
test('rebuilds the model when metadata changes and uses preview routing', async () => {
const refreshedModel = { id: 'refreshed-model' }
FormModel.mockImplementationOnce(
() => formModelInstance
).mockImplementationOnce(() => refreshedModel)
mockFormsService.getFormMetadata
.mockResolvedValueOnce({ ...metadata, notificationEmail: undefined })
.mockResolvedValueOnce({
...metadata,
notificationEmail: undefined,
live: { updatedAt: new Date('2024-12-01T09:00:00Z') }
})
const model = await resolveFormModel(server, slug, 'preview', {
ordnanceSurveyApiKey: 'os-api-key'
})
const rebuilt = await resolveFormModel(server, slug, 'preview')
expect(model).toBe(formModelInstance)
expect(rebuilt).toBe(refreshedModel)
expect(FormModel).toHaveBeenCalledTimes(2)
expect(mockFormsService.getFormDefinition).toHaveBeenCalledTimes(2)
expect(mockCheckEmailAddressForLiveFormSubmission).toHaveBeenCalledWith(
undefined,
true
)
expect(FormModel).toHaveBeenCalledWith(
definition,
expect.objectContaining({
basePath: 'forms/preview/live/tb-origin',
ordnanceSurveyApiKey: 'os-api-key',
formId: metadata.id
}),
mockServices,
undefined
)
})
test('throws when requested form state does not exist on metadata', async () => {
mockFormsService.getFormMetadata.mockResolvedValue({
id: 'metadata-123',
live: { updatedAt: new Date('2024-10-15T10:00:00Z') }
})
await expect(
resolveFormModel(server, slug, FormStatus.Draft)
).rejects.toThrow("No 'draft' state for form metadata metadata-123")
expect(FormModel).not.toHaveBeenCalled()
})
test('throws when no form definition is available for the requested state', async () => {
mockFormsService.getFormDefinition.mockResolvedValue(undefined)
await expect(
resolveFormModel(server, slug, FormStatus.Live)
).rejects.toThrow(
`No definition found for form metadata ${metadata.id} (${slug}) ${FormStatus.Live}`
)
expect(FormModel).not.toHaveBeenCalled()
expect(mockCheckEmailAddressForLiveFormSubmission).not.toHaveBeenCalled()
})
})
describe('getFirstJourneyPage helper', () => {
const buildPage = (path: string, keys: string[] = []) =>
({ path, keys }) as unknown as PageControllerClass
test('returns undefined when no context or relevant target path is available', () => {
expect(getFirstJourneyPage()).toBeUndefined()
expect(getFirstJourneyPage({ relevantPages: [] })).toBeUndefined()
})
test('returns the page matching the last recorded path', () => {
const startPage = buildPage('/start')
const nextPage = buildPage('/animals')
const context: Pick<FormContext, 'relevantPages'> = {
relevantPages: [startPage, nextPage]
}
expect(getFirstJourneyPage(context)).toBe(nextPage)
})
test('steps back from terminal pages to the previous relevant page', () => {
const startPage = buildPage('/start')
const exitPage = Object.assign(new MockTerminalPageController(), {
path: '/stop'
}) as unknown as PageControllerClass
const context: Pick<FormContext, 'relevantPages'> = {
relevantPages: [startPage, exitPage]
}
expect(getFirstJourneyPage(context)).toBe(startPage)
})
test('returns the terminal page when it is the only relevant page available', () => {
const exitPage = Object.assign(new MockTerminalPageController(), {
path: '/stop'
}) as unknown as PageControllerClass
const context: Pick<FormContext, 'relevantPages'> = {
relevantPages: [exitPage]
}
expect(getFirstJourneyPage(context)).toBe(exitPage)
})
})
/**
* @import { FormContext } from '../types.js'
*/