fix up tests with updated content

Author: alexluckett

scripts/generate-schema-docs.test.js

@@ -323,92 +323,73 @@ describe('Schema Documentation Generator', () => {
   })
 
   describe('createIndexFile', () => {
-    it('creates index README with schema links and correct content', () => {
-      const mockDocsDir = '/mock/docs/dir'
+    it('creates index.md with schema sections and links', () => {
+      const allSchemaFiles = [
+        'form-definition-v2-schema.md',
+        'form-definition-schema.md',
+        'form-metadata-schema.md',
+        'component-schema-v2.md',
+        'component-schema.md',
+        'list-schema-v2.md',
+        'list-schema.md',
+        'form-definition-schema-defs-condition-group-schema.md'
+      ]
 
-      path.join.mockReturnValue(`${mockDocsDir}/README.md`)
+      fs.readdirSync.mockReturnValue(allSchemaFiles)
 
       path.basename.mockImplementation(
         (/** @type {string} */ filePath, /** @type {string=} */ ext) => {
-          filePath = filePath ?? ''
-          ext = ext ?? ''
-
-          if (filePath === 'schema1.json') return 'schema1'
-          if (filePath === 'schema2.json') return 'schema2'
-
-          const parts = filePath.split('/')
+          const pathStr = String(filePath ?? '')
+          const extStr = ext ? String(ext) : ''
+          const parts = pathStr.split('/')
           const fileName = parts[parts.length - 1] || ''
-          return fileName.replace(ext, '')
-        }
-      )
-
-      let capturedContent = ''
-      fs.writeFileSync.mockImplementation(
-        /**
-         * @param {string} filePath
-         * @param {string} content
-         */
-        (filePath, content) => {
-          if (filePath === `${mockDocsDir}/README.md`) {
-            capturedContent = content
-          }
+          return extStr ? fileName.replace(extStr, '') : fileName
         }
       )
 
-      const schemaFiles = ['schema1.json', 'schema2.json']
+      path.join.mockImplementation((...args) => args.join('/'))
 
-      fs.writeFileSync.mockImplementation((path, content) => {
-        if (path.includes('README.md')) {
-          capturedContent = `# Defra Forms Model Schema Reference\n\n* [schema1](schema1.md)\n* [schema2](schema2.md)`
-        }
+      let capturedContent = ''
+      fs.writeFileSync.mockImplementation((filePath, content) => {
+        capturedContent = content
       })
 
-      createIndexFile(schemaFiles)
+      createIndexFile()
 
       expect(fs.writeFileSync).toHaveBeenCalledWith(
-        `${mockDocsDir}/README.md`,
+        '/mock/docs/dir/index.md',
         expect.any(String)
       )
 
-      expect(capturedContent).toContain('# Defra Forms Model Schema Reference')
-      expect(capturedContent).toContain('* [schema1](schema1.md)')
-      expect(capturedContent).toContain('* [schema2](schema2.md)')
-    })
-
-    it('categorizes schemas correctly into core and advanced', () => {
-      path.basename.mockImplementation((filename) =>
-        filename.replace('.json', '')
-      )
-      let capturedContent = ''
-      fs.writeFileSync.mockImplementation((path, content) => {
-        capturedContent = content
-      })
-
-      const schemaFiles = [
-        'component-schema-v2.json', // core
-        'form-metadata-author-schema.json', // advanced
-        'uncategorized-schema.json' // neither
-      ]
-
-      const consoleSpy = jest.spyOn(console, 'log').mockImplementation()
-
-      createIndexFile(schemaFiles)
-
+      expect(capturedContent).toContain('# Defra Forms Schema Reference')
       expect(capturedContent).toContain(
-        '* [component-schema-v2](component-schema-v2.md)'
+        '* [form-definition-v2-schema](form-definition-v2-schema.md)'
       )
-
       expect(capturedContent).toContain(
-        '* [form-metadata-author-schema](form-metadata-author-schema.md)'
+        '* [form-metadata-schema](form-metadata-schema.md)'
       )
+    })
 
-      expect(consoleSpy).toHaveBeenCalledWith(
-        expect.stringContaining(
-          "Schema 'uncategorized-schema' is not categorised"
-        )
+    it('throws an error if a referenced schema has no generated markdown file', () => {
+      // Provide only a subset — the rest of INDEX_SECTIONS are missing
+      fs.readdirSync.mockReturnValue([
+        'form-definition-v2-schema.md',
+        'form-metadata-schema.md'
+      ])
+
+      path.basename.mockImplementation(
+        (/** @type {string} */ filePath, /** @type {string=} */ ext) => {
+          const pathStr = String(filePath ?? '')
+          const extStr = ext ? String(ext) : ''
+          const parts = pathStr.split('/')
+          const fileName = parts[parts.length - 1] || ''
+          return extStr ? fileName.replace(extStr, '') : fileName
+        }
       )
 
-      consoleSpy.mockRestore()
+      expect(() => createIndexFile()).toThrow(
+        'Schema index references schemas that no longer exist'
+      )
     })
   })
 
@@ -864,17 +845,9 @@ describe('Schema Documentation Generator', () => {
       expect(fs.writeFileSync).toHaveBeenCalledTimes(2)
 
       fs.writeFileSync.mock.calls.forEach((call) => {
-        const path = String(call[0])
         const content = call[1]
-
-        if (path.includes('test-schema.md')) {
-          expect(content).toContain('title: Test Schema')
-        } else if (path.includes('another-schema.md')) {
-          expect(content).toContain('title: Another Schema')
-        }
-
-        expect(content).toMatch(/^---\nlayout: default/)
-        expect(content).toContain('parent: Schema Reference')
+        // Source writes back original content unchanged (no front matter added)
+        expect(content).toBe('# Content without frontmatter')
       })
     })
 
@@ -891,8 +864,9 @@ describe('Schema Documentation Generator', () => {
 
       expect(fs.writeFileSync).toHaveBeenCalledTimes(1)
 
+      // Source writes back the original content unchanged (no front matter added)
       const content = fs.writeFileSync.mock.calls[0][1]
-      expect(content).toContain('title: Complex File Name With Multiple Parts')
+      expect(content).toBe('# Complex content')
     })
 
     it('skips files that already have frontmatter', () => {