Merge pull request #294 from DEFRA/fix/DF-717-ref-num-fix

jbarnsley10 · web-flow · commit 4b4fb5015f01 · 2026-01-22T08:34:51.000Z
fix/DF-717: Fixed ref-num being double-generated
diff --git a/src/server/plugins/engine/pageControllers/StatusPageController.ts b/src/server/plugins/engine/pageControllers/StatusPageController.ts
@@ -58,7 +58,7 @@ export class StatusPageController extends QuestionPageController {
         submissionGuidance,
         formName,
         showReferenceNumber: this.showReferenceNumber,
-        referenceNumber: context.referenceNumber
+        referenceNumber: confirmationState.referenceNumber
       })
     }
   }
diff --git a/src/server/plugins/engine/pageControllers/SummaryPageController.ts b/src/server/plugins/engine/pageControllers/SummaryPageController.ts
@@ -174,7 +174,8 @@ export class SummaryPageController extends QuestionPageController {
 
     await cacheService.setConfirmationState(request, {
       confirmed: true,
-      formId: context.state.formId
+      formId: context.state.formId,
+      referenceNumber: context.referenceNumber
     } as FormConfirmationState)
 
     // Clear all form data
diff --git a/src/server/plugins/engine/types.ts b/src/server/plugins/engine/types.ts
@@ -100,6 +100,7 @@ export interface FormSubmissionError
 export interface FormConfirmationState {
   confirmed?: true
   formId?: string
+  referenceNumber?: string
 }
 
 export interface FormPayloadParams {

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ export class StatusPageController extends QuestionPageController {`
`58`	`58`	`submissionGuidance,`
`59`	`59`	`formName,`
`60`	`60`	`showReferenceNumber: this.showReferenceNumber,`
`61`		`- referenceNumber: context.referenceNumber`
	`61`	`+ referenceNumber: confirmationState.referenceNumber`
`62`	`62`	`})`
`63`	`63`	`}`
`64`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,7 @@ export interface FormSubmissionError`
`100`	`100`	`export interface FormConfirmationState {`
`101`	`101`	`confirmed?: true`
`102`	`102`	`formId?: string`
	`103`	`+ referenceNumber?: string`
`103`	`104`	`}`
`104`	`105`
`105`	`106`	`export interface FormPayloadParams {`